Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP8.1] Contact data deprecated errors #38101

Merged
merged 2 commits into from Jun 20, 2022
Merged

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Jun 19, 2022

Fixes deprecated notices when creating contacts with either empty websites or emails. Cause the test sample data to fail to install at the contact stage on PHP 8.1 currently (note after this PR then the newsfeeds fail to install instead - which requires #38102)

@wilsonge wilsonge changed the title [4.2] Contact data [4.2] Contact data deprecated errors Jun 19, 2022
@wilsonge wilsonge added the PHP 8.x PHP 8.x deprecated issues label Jun 19, 2022
@laoneo laoneo added the Maintainers Checked Used if the PR is conceptional useful label Jun 20, 2022
@wilsonge wilsonge changed the title [4.2] Contact data deprecated errors [PHP8.1] Contact data deprecated errors Jun 20, 2022
@alikon
Copy link
Contributor

alikon commented Jun 20, 2022

I have tested this item ✅ successfully on bb026a1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38101.

1 similar comment
@laoneo
Copy link
Member

laoneo commented Jun 20, 2022

I have tested this item ✅ successfully on bb026a1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38101.

@Quy Quy removed the Maintainers Checked Used if the PR is conceptional useful label Jun 20, 2022
@Quy
Copy link
Contributor

Quy commented Jun 20, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38101.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 20, 2022
@roland-d roland-d merged commit 39dd785 into joomla:4.2-dev Jun 20, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 20, 2022
@roland-d
Copy link
Contributor

Thanks everybody

@roland-d roland-d added this to the Joomla 4.2.0 milestone Jun 20, 2022
@wilsonge wilsonge deleted the contact_data branch June 20, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants