[PHP 8.1] Fix indexing newsfeeds with no summary #38102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
force-pushed
the
summary_fix_finder
branch
from
c3843fa
to
30269aa
Compare
laoneo
approved these changes
Jun 20, 2022
Hackwar
approved these changes
Jun 20, 2022
|
I have tested this item ✅ successfully on 30269aa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38102. |
1 similar comment
|
I have tested this item ✅ successfully on 30269aa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38102. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38102. |
Quy
removed
PHP 8.x
|
Thanks everybody |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes indexing news feed items when creating sample data. If no summary is present then it needs a string and not null.
Testing Instructions
Requires parallel application of #38101
Install sample data from Joomla
Actual result BEFORE applying this Pull Request
Errors installing sample data
Expected result AFTER applying this Pull Request
Sample data successfully installs
Documentation Changes Required
N/A