Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] install language - an error message when no xml is returned #38113

Merged
merged 4 commits into from Jun 23, 2022

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Jun 21, 2022

Pull Request for Issue #38110 .

Summary of Changes

added a check if the xml is returned

Testing Instructions

add a $response->body= ""; on line 153 to simulate the case

Actual result BEFORE applying this Pull Request

PHP Warning: Attempt to read property "extension" on bool in /shared/httpd/dev4/joomla-cms/administrator/components/com_installer/src/Model/LanguagesModel.php on line 158

Expected result AFTER applying this Pull Request

a proper error message

@wilsonge wilsonge added the Maintainers Checked Used if the PR is conceptional useful label Jun 21, 2022
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 6d0afcf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38113.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jun 22, 2022

I have tested this item ✅ successfully on 6d0afcf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38113.

@Quy
Copy link
Contributor

Quy commented Jun 22, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38113.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 22, 2022
@wilsonge wilsonge merged commit 7f1b361 into joomla:4.2-dev Jun 23, 2022
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 23, 2022
@wilsonge wilsonge added this to the Joomla 4.2.0 milestone Jun 23, 2022
@alikon alikon deleted the patch-5 branch June 24, 2022 08:56
heelc29 added a commit to heelc29/joomla that referenced this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators Maintainers Checked Used if the PR is conceptional useful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants