Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Fix fatal error on webauthn plugin #38132

Merged
merged 2 commits into from Jun 26, 2022

Conversation

joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

PR #38060 removed $app property from the class, so using $this->app in the layout causes fatal error. We need to use $this->getApplication() to get application object instead.

I also removed an un-used use statement in the plugin layout code.

Testing Instructions

I don't have experience with using the plugin, so please ignore if my testing instructions are wrong

  1. Use Joomla 4.2 nightly build
  2. Make sure Multi-factor Authentication - Web Authentication plugin is enabled
  3. Login to administrator area of your site, edit an user account, look at Multi-factor Authentication tab, click on Add a new Web Authentication button.

Actual result BEFORE applying this Pull Request

Get fatal error: Call to a member function getDocument() on null

Expected result AFTER applying this Pull Request

Error is gone, the page loads OK

@heelc29
Copy link
Contributor

heelc29 commented Jun 24, 2022

I have tested this item ✅ successfully on a5042e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38132.

@richard67
Copy link
Member

I have tested this item ✅ successfully on a5042e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38132.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38132.

@richard67
Copy link
Member

RTC !!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38132.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 26, 2022
@laoneo laoneo merged commit 3e649ba into joomla:4.2-dev Jun 26, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 26, 2022
@laoneo
Copy link
Member

laoneo commented Jun 26, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants