[5.0] order site/admin menus in admin ui #38149

brianteeman · 2022-06-26T23:45:14Z

The site and admin menus displayed in the admin interface sidebar are hard coded to be displayed by id desc

This PR allows the order to be changed using drag and drop from com_menus&view=menus

Pull Request for Issue #38143

When thinking about documentation for this PR I concluded that this is NOT a new feature but its more of a bug that you couldnt sort them before just as you can sort everything else.

To test

Clean install from the prebuilt package in this PR
Create multiple site and admin menus (they dont need any menu items in them for the prupose of this test)
Drag and drop to change the order
Refresh the page and you will see the changes take effect in the sidebar

Update an existing test site using the prebuilt package in this pr
Repeat the steps above.

thanks @HLeithner

currently they are hard coded to be displayed by id desc this pr will (when finished) allows the order to be set using drag and drop from com_menus&view=menus This is for the display of the menus in the sidebar and the menus dashboard todo - [ ] sql update - [ ] sql installation - [ ] saveorderingajax - [ ] add ordering to menu creation

joomla-bot · 2022-06-27T20:06:51Z

This pull requests has been automatically converted to the PSR-12 coding standard.

HLeithner · 2023-05-02T16:42:15Z

This pull request has been automatically rebased to 5.0-dev.

HLeithner · 2023-05-13T14:49:37Z

@brianteeman would be great if you had time to finish this pr I would be happy to merge it into 5.0

brianteeman · 2023-05-13T15:13:58Z

If I knew how I would. That's why I asked for help

HLeithner · 2023-07-10T14:29:33Z

oh sorry I didn't saw your comment, what exactly do you need? or is it the todo list you added where you need help?

installation/sql/mysql/base.sql

installation/sql/postgresql/base.sql

Co-authored-by: Harald Leithner <leithner@itronic.at>

brianteeman · 2023-07-12T09:04:55Z

@HLeithner sorry - had to look at the code again to see where I had left it.

currently stuck at saveorderingajax

probably missing something obvious but I just cant see it

HLeithner · 2023-07-12T18:15:51Z

I updated the controller now it's working

brianteeman · 2023-07-12T18:44:30Z

shucks - i changed the controller but not the model.

will test it tomorrow and see what else needs doing

thanks

HLeithner · 2023-07-13T06:34:28Z

Maybe we should update the ordering column of the existing menu entries when adding the ordering column. Something like update #__menus set ordering=id

brianteeman · 2023-07-13T07:00:16Z

yes I was planning on doing that and also checking the sample data plugins

This reverts commit 552be2827613a9eb37670a00bc316ccbef183933.

administrator/components/com_menus/tmpl/menus/default.php

Co-authored-by: Quy <quy@nomonkeybiz.com>

chmst · 2023-07-13T20:11:58Z

Resolves #39236

chmst · 2023-07-13T20:14:39Z

The ordering of menu Items will be a challenge. First tests look very promising. Thanks for that @brianteeman

brianteeman · 2023-07-13T20:28:33Z

The ordering of menu Items will be a challenge.

Not sure what you mean. This PR is about ordering the menus not the items

chmst · 2023-07-13T20:58:42Z

Sorry, forget it. Multi-tasking-failure ;)

bayareajenn · 2023-07-14T15:26:33Z

I have tested this item ✅ successfully on 9b311a2

Tested new install and tested by updating an instance. Really great, nice to have. Thanks, Brian. :)

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38149.}

HLeithner · 2023-07-17T12:07:02Z

thanks

brianteeman · 2023-07-17T12:07:35Z

thanks

richard67 · 2023-07-17T12:13:43Z

administrator/components/com_admin/sql/updates/postgresql/5.0.0-2023-07-12.sql

@@ -0,0 +1,2 @@
+ALTER TABLE "#__menu_types" ADD COLUMN "ordering" int NOT NULL DEFAULT 0 AFTER "client_id";


PostgreSQL doesn't support "AFTER", so this will result in an SQL syntax error when updating on PostgreSQL.

thanks can you fix it please?

Can take a while because I have to boot my environment and update my branches.

PR is #41177 .

I just see the update SQL scripts are also missing the ´/** CAN FAIL **/` installer hint. PR is in preparation.

PR is #41184 .

joomla-cms-bot added the PR-4.2-dev label Jun 26, 2022

joomla-bot added 3 commits June 27, 2022 22:06

Merge tag 'psr12anchor' into psr12/merge/38149

9724e8a

Phase 1 convert BRANCH to PSR-12

3679b53

Merge tag 'psr12final' into psr12/merge/38149

2ff5e31

joomla-bot added the psr12 label Jun 27, 2022

brianteeman mentioned this pull request Jun 28, 2022

[4.1] Wrong menu list order in the administration menu. #38143

Closed

HLeithner removed the psr12 label Oct 23, 2022

crystalenka mentioned this pull request Nov 18, 2022

Make Menus in Admin Menu sortable #39236

Closed

Hackwar added the Feature label Apr 6, 2023

HLeithner changed the base branch from 4.2-dev to 5.0-dev May 2, 2023 16:42

alikon added PR-5.0-dev and removed PR-4.2-dev labels May 22, 2023

HLeithner changed the title ~~[wip] order site menus in admin ui~~ [5.0] order site menus in admin ui Jul 10, 2023

Merge branch '5.0-dev' into menu_order

5139a3e

brianteeman marked this pull request as ready for review July 12, 2023 07:58

brianteeman marked this pull request as draft July 12, 2023 07:58

brianteeman added 2 commits July 12, 2023 09:13

update sql

c43097a

install sql

8020bee

HLeithner reviewed Jul 12, 2023

View reviewed changes

installation/sql/mysql/base.sql Outdated Show resolved Hide resolved

installation/sql/postgresql/base.sql Outdated Show resolved Hide resolved

brianteeman and others added 2 commits July 12, 2023 10:03

Update installation/sql/mysql/base.sql

b46fa29

Co-authored-by: Harald Leithner <leithner@itronic.at>

Update installation/sql/postgresql/base.sql

9a92b3c

Co-authored-by: Harald Leithner <leithner@itronic.at>

Change Controller and Model to Admin variants

f333071

brianteeman added 5 commits July 13, 2023 09:29

set ordering on new installs

70bd691

set the ordering to the itemid on update

ec76eff

sorting of admin menutypes

a8fa1b2

auto increment the ordering column

238ec17

Revert "Auxiliary commit to revert individual files from 238ec17"

bc40e12

This reverts commit 552be2827613a9eb37670a00bc316ccbef183933.

brianteeman changed the title ~~[5.0] order site menus in admin ui~~ [5.0] order site/admin menus in admin ui Jul 13, 2023

brianteeman marked this pull request as ready for review July 13, 2023 09:52

Quy reviewed Jul 13, 2023

View reviewed changes

administrator/components/com_menus/tmpl/menus/default.php Outdated Show resolved Hide resolved

Update administrator/components/com_menus/tmpl/menus/default.php

9b311a2

Co-authored-by: Quy <quy@nomonkeybiz.com>

HLeithner merged commit e8d462f into joomla:5.0-dev Jul 17, 2023
3 of 4 checks passed

brianteeman deleted the menu_order branch July 17, 2023 12:07

richard67 reviewed Jul 17, 2023

View reviewed changes

richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 17, 2023

Fix SQL syntax error from PR joomla#38149

425e791

richard67 mentioned this pull request Jul 17, 2023

[5.0] Fix SQL syntax error when updating on PotgsreSQL caused by PR #38149 #41177

Merged

2 tasks

HLeithner pushed a commit that referenced this pull request Jul 17, 2023

Fix SQL syntax error from PR #38149 (#41177)

094f544

Fedik mentioned this pull request Jul 18, 2023

[5.0] Potential upgrade issue, that can lead to blocked backend #41181

Closed

richard67 mentioned this pull request Jul 18, 2023

[5.0] Add missing "/** CAN FAIL **/" to update SQL scripts from PR #38149 #41184

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.0] order site/admin menus in admin ui #38149

[5.0] order site/admin menus in admin ui #38149

brianteeman commented Jun 26, 2022 •

edited

joomla-bot commented Jun 27, 2022

HLeithner commented May 2, 2023

HLeithner commented May 13, 2023

brianteeman commented May 13, 2023

HLeithner commented Jul 10, 2023

brianteeman commented Jul 12, 2023

HLeithner commented Jul 12, 2023

brianteeman commented Jul 12, 2023

HLeithner commented Jul 13, 2023

brianteeman commented Jul 13, 2023

chmst commented Jul 13, 2023

chmst commented Jul 13, 2023

brianteeman commented Jul 13, 2023

chmst commented Jul 13, 2023

bayareajenn commented Jul 14, 2023

HLeithner commented Jul 17, 2023

brianteeman commented Jul 17, 2023

richard67 Jul 17, 2023

HLeithner Jul 17, 2023

richard67 Jul 17, 2023

richard67 Jul 17, 2023

richard67 Jul 18, 2023

richard67 Jul 18, 2023

		@@ -0,0 +1,2 @@
		ALTER TABLE "#__menu_types" ADD COLUMN "ordering" int NOT NULL DEFAULT 0 AFTER "client_id";

[5.0] order site/admin menus in admin ui #38149

[5.0] order site/admin menus in admin ui #38149

Conversation

brianteeman commented Jun 26, 2022 • edited

To test

joomla-bot commented Jun 27, 2022

HLeithner commented May 2, 2023

HLeithner commented May 13, 2023

brianteeman commented May 13, 2023

HLeithner commented Jul 10, 2023

brianteeman commented Jul 12, 2023

HLeithner commented Jul 12, 2023

brianteeman commented Jul 12, 2023

HLeithner commented Jul 13, 2023

brianteeman commented Jul 13, 2023

chmst commented Jul 13, 2023

chmst commented Jul 13, 2023

brianteeman commented Jul 13, 2023

chmst commented Jul 13, 2023

bayareajenn commented Jul 14, 2023

HLeithner commented Jul 17, 2023

brianteeman commented Jul 17, 2023

richard67 Jul 17, 2023

Choose a reason for hiding this comment

HLeithner Jul 17, 2023

Choose a reason for hiding this comment

richard67 Jul 17, 2023

Choose a reason for hiding this comment

richard67 Jul 17, 2023

Choose a reason for hiding this comment

richard67 Jul 18, 2023

Choose a reason for hiding this comment

richard67 Jul 18, 2023

Choose a reason for hiding this comment

brianteeman commented Jun 26, 2022 •

edited