Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Code style for webauthn plugin #38191

Merged
merged 3 commits into from Jun 30, 2022
Merged

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Jun 30, 2022

Summary of Changes

Code style for changes in #37910

Testing Instructions

Code review

@richard67
Copy link
Member

I have tested this item ✅ successfully on a0054c2

Ok by review, and code style checks still succeed in drone.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38191.

@Quy
Copy link
Contributor

Quy commented Jun 30, 2022

I have tested this item ✅ successfully on a0054c2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38191.

@Quy
Copy link
Contributor

Quy commented Jun 30, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38191.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 30, 2022
@richard67
Copy link
Member

@HLeithner Any idea why PHPCS doesn't complain about the code style in that file without this PR?

@laoneo laoneo merged commit 197723f into joomla:4.2-dev Jun 30, 2022
@laoneo
Copy link
Member

laoneo commented Jun 30, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 30, 2022
@laoneo laoneo added this to the Joomla! 4.2.0 milestone Jun 30, 2022
@heelc29 heelc29 deleted the issue-cs-37910 branch July 1, 2022 14:28
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants