Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] CLI user scripts cleanup #38210

Merged
merged 6 commits into from Jul 3, 2022
Merged

[4.2] CLI user scripts cleanup #38210

merged 6 commits into from Jul 3, 2022

Conversation

brianteeman
Copy link
Contributor

This is part of a series of pr (broken down to smaller ones to make testing easier) that fixes several issues in the cli commands.

  1. Make sure the title is displayed
  2. Make sure the case of the title matches the styleguide
  3. Make sure table column headings match the styleguide

Before and after

Delete User

EeAtdW7eP6

Add User

ETNKnNtukE

Add user to group

JmrYkA44pS

Remove user from group

VSLxzhiV95

@brianteeman brianteeman changed the title [4.1] CLI user scripts cleanup [4.2] CLI user scripts cleanup Jul 3, 2022
@alikon
Copy link
Contributor

alikon commented Jul 3, 2022

I have tested this item ✅ successfully on d2f0cf4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38210.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on d2f0cf4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38210.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38210.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 3, 2022
@roland-d roland-d merged commit ee2d763 into joomla:4.2-dev Jul 3, 2022
@roland-d
Copy link
Contributor

roland-d commented Jul 3, 2022

Thank you

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 3, 2022
@roland-d roland-d modified the milestones: Joomla! 4.3.0, Joomla! 4.2.0 Jul 3, 2022
@brianteeman brianteeman deleted the clibug branch July 3, 2022 17:35
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Jul 12, 2022
* Add User

* sadd user to group - case and position

* delete user

* title and columns

* title

* title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants