Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Fix issue "updateCheck is null" #38519

Merged
merged 2 commits into from Aug 18, 2022

Conversation

fancyFranci
Copy link
Contributor

Pull Request for Issue #38513.

Summary of Changes

Going to the joomla updater can lead to a js error because an optional element can not be found. This PR checks the element before it is used.

Testing Instructions

Short: Follow the instructions in the linked issue.
Long:
Open the developer tools of your browser to see the console.
Go to System -> Global Configuration -> Joomla! Update.
Try out different channels.
Everytime you click "Save & Close" you are redirected to the update page.
There you can click buttons like "Reinstall Joomla! core files"

Actual result BEFORE applying this Pull Request

An js error saying "TypeError: updateCheck is null" appears in the browser console. Depending on your debug settings it could say "a is null" or something like this. Buttons are not working.

Expected result AFTER applying this Pull Request

There is no js error and buttons should work as always.

Documentation Changes Required

Nope.

@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Aug 18, 2022
@zero-24
Copy link
Contributor

zero-24 commented Aug 18, 2022

I have tested this item ✅ successfully on 65394e0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38519.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 65394e0

I did not get a JS error in my browser console without this PR. But I can confirm that without this PR, the button to reinstall the core files doesn't work, and with this PR it does work.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38519.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 4.2.1 milestone Aug 18, 2022
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38519.

@richard67
Copy link
Member

RTC !


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38519.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 18, 2022
@richard67 richard67 added this to the Joomla! 4.2.1 milestone Aug 18, 2022
@roland-d roland-d merged commit 147911f into joomla:4.2-dev Aug 18, 2022
@roland-d
Copy link
Contributor

Thank you

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 18, 2022
@fancyFranci fancyFranci deleted the 38513_fix-updatecheck-is-null branch March 26, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants