Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Remove hotkeys.js by script.php #38523

Merged
merged 3 commits into from Aug 18, 2022

Conversation

fancyFranci
Copy link
Contributor

@fancyFranci fancyFranci commented Aug 18, 2022

Pull Request for Issue # .

Summary of Changes

While the development of 4.2 hotkeys.js was renamed to hotkeysjs to avoid issues. Currently both are in the build may be on sites, but the one with the dot should be removed with all its files and folders.

@richard67 please have a look

@richard67
Copy link
Member

Currently both are in the build

@fancyFranci That should not be the case. But the old folder and files may still be there on sites updated from pervious versions, and that's what will be deleted on update with your change.

fancyFranci and others added 2 commits August 18, 2022 20:52
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@richard67 richard67 added the Maintainers Checked Used if the PR is conceptional useful label Aug 18, 2022
@roland-d roland-d merged commit 152ebcc into joomla:4.2-dev Aug 18, 2022
@fancyFranci fancyFranci deleted the remove-hotkeys-dot-js branch March 26, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainers Checked Used if the PR is conceptional useful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants