Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the autoload_psr4 before running finalisation.php #38525

Merged
merged 1 commit into from Aug 18, 2022
Merged

Remove the autoload_psr4 before running finalisation.php #38525

merged 1 commit into from Aug 18, 2022

Conversation

nikosdion
Copy link
Contributor

Replaces #38491

Pull Request for Issue #38486 .

Summary of Changes

Add code in extract.php to remove the administrator/cache/autoload_psr4.php file before loading the finalisation.php as the latter might try to use core code which depends on the former.

Testing Instructions

From Joomla 4.0.0

  • Install a Joomla 4.0.0 site
  • Replace administrator/components/com_joomlaupdate, components/com_joomlaupdate, media/com_joomlaupdate, and administrator/language/en-GB/com_joomlaupdate.* with the files from this PR.
  • Log into the backend
  • Do an md5sum of the administrator/cache/autoload_psr4.php file
  • Upgrade the site to Joomla 4.2 using the package built from this PR
  • Try to access your site's frontend
  • Do an md5sum of the administrator/cache/autoload_psr4.php file

From Joomla 4.1.5

  • Install a Joomla 4.1.5 site
  • Log into the backend
  • Do an md5sum of the administrator/cache/autoload_psr4.php file
  • Upgrade the site to Joomla 4.2 using the package built from this PR
  • Try to access your site's frontend
  • Do an md5sum of the administrator/cache/autoload_psr4.php file

Actual result BEFORE applying this Pull Request

The MD5 sums are identical (the autoload_psr4.php file was not removed on update).

Expected result AFTER applying this Pull Request

The MD5 sums are different (the autoload_psr4.php file was removed on update and replaced when accessing your site again).

Documentation Changes Required

None.

@richard67 richard67 added this to the Joomla! 4.2.1 milestone Aug 18, 2022
@roland-d roland-d merged commit 30ab12a into joomla:4.2-dev Aug 18, 2022
@nikosdion nikosdion deleted the fix/38486-part1-autoload-psr4 branch May 10, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants