Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1]Installation Language #38573

Merged
merged 16 commits into from Mar 14, 2024
Merged

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #36048 .

Summary of Changes

At present the Language Selection in Joomla Installer displays only the nativeName in the list. This makes language names to display in different places not alphabetically by [English] name. This is true especially for language names that do not contain Latin characters. For example, Spanish would appear immediately after English as the native name for Spanish is Español. You can also notice other language such as Tamil (with native name தமிழ்)is listed after the English alphabet names.

Suggestion is to show the language name (ie English Name) along with native name in the list and the list sorted in the language name. This would help to see the languages alphabetically in English. In addition, it would help to find the language easily.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

@Kostelano
Copy link
Contributor

It still depends on localization teams. There are several languages where the <nativeName> and <name> headers are reversed.

Someone needs to contact the localization teams (e.g. Bulgarian, etc.) and fix this. Then we get the result you describe - "alphabetical" and "easy to find".

Just in case, I'll note @tecpromotion. Don't kick me if it's none of your business :).

@brianteeman
Copy link
Contributor Author

I raised this a long long time ago so I 10000% agree

And you pr got rejected? If you create a pr I would support it.

@Hackwar Hackwar added the Feature label Apr 6, 2023
@HLeithner HLeithner changed the base branch from 4.2-dev to 5.0-dev May 2, 2023 16:42
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.0-dev.

@brianteeman
Copy link
Contributor Author

@HLeithner I made this because you asked

@HLeithner
Copy link
Member

@brianteeman thanks for bringing this up again, I will check and find some testers hopefully soon.

@brianteeman brianteeman closed this Sep 8, 2023
@brianteeman brianteeman deleted the language_sort branch September 8, 2023 11:50
@brianteeman brianteeman restored the language_sort branch September 24, 2023 07:59
@brianteeman brianteeman reopened this Sep 24, 2023
@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:51
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@brianteeman brianteeman changed the title Installation Language [5.1]Installation Language Sep 30, 2023
@Quy Quy removed the PR-5.0-dev label Sep 30, 2023
@brianteeman
Copy link
Contributor Author

If this PR is never going to be accepted then please close it. I only made it at the request of the release lead

@HLeithner
Copy link
Member

alpha2 packages are already ready... @LadySolveig can you merge this at some point in time?

@LadySolveig
Copy link
Contributor

@HLeithner @brianteeman sure - it would be a shame if it got lost. I see no tests yet. I will ask for tests again and hopefully merge soon.

@richard67
Copy link
Member

richard67 commented Dec 19, 2023

The system tests fail at installing. Can be seen here when using the "show all logs" at the top or downloading the complete log. The log then shows:

1) Install Joomla
       Install Joomla:
     CypressError: Timed out retrying after 4000ms: `cy.select()` failed because it could not find a single `<option>` with value, index, or text matching: `English (United Kingdom)`

It happens in file tests/System/integration/install/Installation.cy.js.

@brianteeman Do you think you can adapt the system tests to your change, or should we try to find someone who can help? Unfortunately I have no knowledge on Cypress.

P.S.: This should not keep people from testing, any later fix for the system tests will not influence the result of human tests.

alikon added a commit to alikon/joomla-cypress that referenced this pull request Dec 19, 2023
@dautrich
Copy link

dautrich commented Dec 19, 2023

I have tested this item ✅ successfully on d42fc0a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38573.

J5 1_Test2

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38573.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 19, 2023
@richard67
Copy link
Member

I've set RTC despite of the failing system tests as @LadySolveig told me that she will adjust the tests when this PR gets merged.

@richard67
Copy link
Member

I just see there is already a PR for adjusting the system tests: joomla-projects/joomla-cypress#11

Thanks @alikon .

rdeutz pushed a commit to joomla-projects/joomla-cypress that referenced this pull request Jan 3, 2024
LadySolveig added a commit to LadySolveig/joomla-cms that referenced this pull request Jan 5, 2024
@brianteeman
Copy link
Contributor Author

Any reason why this RTC pull request is not being merged?

e2e test installation - language sort
@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Feb 24, 2024
@joomla-cms-bot joomla-cms-bot removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Mar 14, 2024
@LadySolveig
Copy link
Contributor

Thank you @brianteeman and for the review and for testing to @richard67 @dautrich

@LadySolveig LadySolveig merged commit 465d2d0 into joomla:5.1-dev Mar 14, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 14, 2024
@brianteeman
Copy link
Contributor Author

yay!!

@brianteeman brianteeman deleted the language_sort branch March 14, 2024 17:42
@Quy Quy added this to the Joomla! 5.1.0 milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet