New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Fix Tinymce and Codemirror version #38614
Conversation
I've just checked and can confirm that this PR here is complete, i.e. the version numbers in files "plugins/editors/codemirror/codemirror.xml" and "plugins/editors/tinymce/tinymce.xml" were not downgraded by PR #38422 and so still are right. @brianteeman Could you have a look, too? Maybe I'm missing something? |
is this even needed. It is for the 4.3 branch and when the next upmerge is done it will be resolved. And hopefully then it will have the latest updates merged. Note: When you want to update a package you only do npm update package and not blindly npm update everything |
@brianteeman Not necessarily because the PR which downgraded the versions on 4.3-dev was committed after the ones which upgraded them on 4.2-dev, so there will not be any conflict on the upmerge, and git will keep it as it is. So I think this PR here is good to make sure it goes the right way. But you are right when there will be an update on these places in the package lock on the 4.2-dev branch later. Then this PR here will not be needed anymore because that later change would go up with the next upmerge after that. |
Fully correct. The mistake has happened when PR #38422 was merged, and that PR changed also other dependencies which should be checked. When doing like @brianteeman said, the package lock should show only expected changes for the updated package and its dependencies. The same applies to composer dependencies. |
I have tested this item ✅ successfully on d9df238 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38614. |
I have tested this item ✅ successfully on d9df238 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38614. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38614. |
Thanks @heelc29. Can you update your branch so I can merge your changes? Thank you! |
@obuisard you should have the rights to update the branch. |
Hi Brian, it does not seem like I do, unless it is possible other than from the Github interface. |
@obuisard then you need to speak to the other maintainers as they all can. Its crazy if you dont and it will take forever to get things merged. (unless the user has marked this as cannot be updated - can you update other PR?) |
Actually, you are right, I can update branches on other PRs, just not the ones from @heelc29. Thank you Brian. |
Thank you @heelc29 for the PR :-) |
Summary of Changes
With PR #38422 the versions of codemirror and tinymce was downgraded:
This PR updated these extensions back to:
Testing Instructions
code review