-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Load plugin group when executing batch tasks #39013
Conversation
Is there a reason to drop this in each function rather than in the common initBatch function? |
We had a discussion that with overriding and... I'll change it. 😉 |
So now the content plugins will be triggered regardless if the method returns false, is that desirable behaviour? |
This PR does not execute any plugins. It just loads the plugin group. The actual events are only executed in the single steps. |
I have tested this item ✅ successfully on d0f01a6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39013. |
I have tested this item ✅ successfully on 23247a9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39013. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39013. |
Thank you Hannes! |
Summary of Changes
@grantg182 found an issue in J3 that batch operations aren't loading the content plugin group. He provided a quick fix in #38378, but since we don't do bugfixes in J3 anymore, this is unfortunately not acceptable anymore. However, this is still valid in J4 and thus this PR introduces loading these plugins in batch properly.
Testing Instructions
Add a
die();
in the beginning of a content plugin. Batch move a few articles. See that it goes through. Apply patch. Move the articles again. See that you get a white screen because the content plugins are loaded.Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed