Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Load plugin group when executing batch tasks #39013

Merged
merged 8 commits into from
Oct 21, 2023

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Oct 21, 2022

Summary of Changes

@grantg182 found an issue in J3 that batch operations aren't loading the content plugin group. He provided a quick fix in #38378, but since we don't do bugfixes in J3 anymore, this is unfortunately not acceptable anymore. However, this is still valid in J4 and thus this PR introduces loading these plugins in batch properly.

Testing Instructions

Add a die(); in the beginning of a content plugin. Batch move a few articles. See that it goes through. Apply patch. Move the articles again. See that you get a white screen because the content plugins are loaded.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@wilsonge
Copy link
Contributor

Is there a reason to drop this in each function rather than in the common initBatch function?

@Hackwar
Copy link
Member Author

Hackwar commented Oct 22, 2022

We had a discussion that with overriding and... I'll change it. 😉

@grantg182
Copy link

So now the content plugins will be triggered regardless if the method returns false, is that desirable behaviour?

@Hackwar
Copy link
Member Author

Hackwar commented Oct 23, 2022

This PR does not execute any plugins. It just loads the plugin group. The actual events are only executed in the single steps.

@Hackwar Hackwar added the Small A PR which only has a small change label Feb 26, 2023
@Hackwar Hackwar added the bug label Apr 7, 2023
@Hackwar Hackwar closed this Apr 18, 2023
@Hackwar Hackwar reopened this Apr 18, 2023
@Hackwar Hackwar changed the base branch from 4.3-dev to 5.0-dev April 18, 2023 12:57
@Hackwar Hackwar changed the title Load plugin group when executing batch tasks [5.0] Load plugin group when executing batch tasks Apr 18, 2023
@laoneo laoneo removed the PR-4.3-dev label May 8, 2023
@Hackwar Hackwar added the PBF Pizza, Bugs and Fun label Aug 25, 2023
@HLeithner HLeithner added Feature Maintainers Checked Used if the PR is conceptional useful and removed bug labels Oct 5, 2023
@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev October 5, 2023 10:04
@HLeithner HLeithner changed the title [5.0] Load plugin group when executing batch tasks [5.1] Load plugin group when executing batch tasks Oct 5, 2023
@chmst
Copy link
Contributor

chmst commented Oct 11, 2023

I have tested this item ✅ successfully on d0f01a6

Tested following the instructions, works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39013.

@Quy Quy removed the PR-5.0-dev label Oct 11, 2023
@LadySolveig
Copy link
Contributor

I have tested this item ✅ successfully on 23247a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39013.

@bembelimen
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39013.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 21, 2023
@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Oct 21, 2023
@LadySolveig LadySolveig merged commit 3d55e78 into joomla:5.1-dev Oct 21, 2023
1 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 21, 2023
@LadySolveig
Copy link
Contributor

Thank you Hannes!

@Hackwar Hackwar deleted the 4.3-batch-events branch March 22, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Maintainers Checked Used if the PR is conceptional useful PBF Pizza, Bugs and Fun PR-5.1-dev Small A PR which only has a small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.