Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Show message "No Media Found" for empty folder in Media Manager #39518

Closed
wants to merge 33 commits into from
Closed

[4.3] Show message "No Media Found" for empty folder in Media Manager #39518

wants to merge 33 commits into from

Conversation

rajputanuj31
Copy link
Contributor

@rajputanuj31 rajputanuj31 commented Dec 28, 2022

Pull Request for Issue #31340

Added message for no media files-
If no media files in Media then message no media files will be displayed to user if user clicked on checkbox

Testing Instructions

Create a new folder in Media and open it (No files should be present)

Expected Result Before PR

No message

Expected Result After PR

A message "No Media Found" will be displayed

Added a message for no media files- 
when there exist no media files in Media a message will be displayed to user when user clicked the checkbox.
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Dec 28, 2022
@brianteeman
Copy link
Contributor

this is only good for english

@richard67
Copy link
Member

@rajputanuj31 Joomla has to work with other languages than English, too, so we can't use a hardcoded English text here.

@richard67 richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Dec 28, 2022
@chmst
Copy link
Contributor

chmst commented Dec 28, 2022

@rajputanuj31 thanks for your contribution! Skills in vue.js are very appreciated.
Joomla is a huge system and of course you cannot know everything - but you can learn,
If you are interested in GSoC 2023, join us on mattermost https://joomlacommunity.cloud.mattermost.com/main/channels/gsoc2023

@dgrammatiko
Copy link
Contributor

Please check how to use the if/else conditionals on the html part of the vue file. You don't have to create elements manually as vue has a simpler way for that...

@fancyFranci
Copy link
Contributor

Great to see that you worked on the issue and want to contribute your result!
Every pull request needs 2 successful user tests. To have a higher chance to get those tests: Please have a look on the descriptions of other pull requests here and how they are structured. "Summary of Changes", "Testing Instructions", before and after applying the patch etc. Add this structure to your PR description as well and you will make it easier for others to test your changes. Screenshots are very helpful too.

@rajputanuj31 rajputanuj31 marked this pull request as draft January 20, 2023 17:17
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Jan 20, 2023
@rajputanuj31 rajputanuj31 marked this pull request as ready for review January 20, 2023 18:37
@Quy Quy removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Jan 20, 2023
…s/browser/browser.vue

Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
@richard67 richard67 changed the title GitHub Issue #31340 [4.2] Show message "No Media Found" for empty folder in Media Manager - fix GitHub issue #31340 Jan 22, 2023
@richard67
Copy link
Member

@rajputanuj31 You have to add the new string also to the administrator language file below this line here:

. Otherwise you see "COM_MEDIA_NO_MEDIA_FOUND" instead of "No Media Found" when using the Media Manager in backend (administrator).

@fancyFranci fancyFranci changed the title [4.2] Show message "No Media Found" for empty folder in Media Manager - fix GitHub issue #31340 [4.2] Show message "No Media Found" for empty folder in Media Manager Jan 22, 2023
@richard67
Copy link
Member

I have tested this item ✅ successfully on ccd8519


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39518.

1 similar comment
@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on ccd8519


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39518.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39518.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 22, 2023
@obuisard obuisard changed the base branch from 4.2-dev to 4.3-dev January 26, 2023 18:40
@obuisard obuisard changed the title [4.2] Show message "No Media Found" for empty folder in Media Manager [4.3] Show message "No Media Found" for empty folder in Media Manager Jan 26, 2023
@Quy Quy removed the PR-4.2-dev label Jan 26, 2023
@dgrammatiko
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on ccd8519


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39518.

@dgrammatiko
Copy link
Contributor

dgrammatiko commented Jan 26, 2023

@richard67 please remove the RTC flag here. This still needs:

  • better css/presentaion (ie resemble the other empty state pages)
  • be aware of the loading state (ie not display until fetching of the data is complete)
  • tweaks on the list view

For the first 2 the code exists in #39709 the 3rd one needs some tweaks on the relative component

@Quy Quy added PR-4.2-dev PR-4.3-dev Updates Requested Indicates that this pull request needs an update from the author and should not be tested. and removed RTC This Pull Request is Ready To Commit PR-4.3-dev PR-4.2-dev labels Jan 26, 2023
@rajputanuj31
Copy link
Contributor Author

@dgrammatiko since the base branch has been changed and there are lot of conflicts. I am unable to understand what should I do. Please guide me a bit.

@rajputanuj31
Copy link
Contributor Author

Created New PR:#39731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev Updates Requested Indicates that this pull request needs an update from the author and should not be tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet