New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Show message "No Media Found" for empty folder in Media Manager #39518
Conversation
Added a message for no media files- when there exist no media files in Media a message will be displayed to user when user clicked the checkbox.
this is only good for english |
@rajputanuj31 Joomla has to work with other languages than English, too, so we can't use a hardcoded English text here. |
@rajputanuj31 thanks for your contribution! Skills in vue.js are very appreciated. |
Please check how to use the if/else conditionals on the html part of the vue file. You don't have to create elements manually as vue has a simpler way for that... |
Great to see that you worked on the issue and want to contribute your result! |
administrator/components/com_media/resources/scripts/components/toolbar/toolbar.vue
Outdated
Show resolved
Hide resolved
Took help of #39690 issue to check it locally and it works fine.
administrator/components/com_media/resources/scripts/components/browser/browser.vue
Outdated
Show resolved
Hide resolved
…s/browser/browser.vue Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
@rajputanuj31 You have to add the new string also to the administrator language file below this line here:
|
I have tested this item ✅ successfully on ccd8519 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39518. |
1 similar comment
I have tested this item ✅ successfully on ccd8519 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39518. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39518. |
I have tested this item 🔴 unsuccessfully on ccd8519 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39518. |
@richard67 please remove the RTC flag here. This still needs:
For the first 2 the code exists in #39709 the 3rd one needs some tweaks on the relative component |
@dgrammatiko since the base branch has been changed and there are lot of conflicts. I am unable to understand what should I do. Please guide me a bit. |
Created New PR:#39731 |
Pull Request for Issue #31340
Added message for no media files-
If no media files in Media then message no media files will be displayed to user if user clicked on checkbox
Testing Instructions
Create a new folder in Media and open it (No files should be present)
Expected Result Before PR
No message
Expected Result After PR
A message "No Media Found" will be displayed