Fix deprecation warning (PHP 8.1+) #39881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix deprecation warning with PHP 8.1+
If a replacement string is used, but no 'quicktask' is defined `$params->get('menu-quicktask')` will return `null` which is deprecated in PHP 8.1+.
Deprecated: str_replace(): Passing null to parameter joomla#3 ($subject) of type array|string is deprecated in administrator/components/com_menus/src/Helper/MenusHelper.php on line 894
laoneo
approved these changes
Feb 17, 2023
|
I have tested this item ✅ successfully on 5587796 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39881. |
|
I have tested this item ✅ successfully on 5587796 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39881. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39881. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deprecation warning with PHP 8.1+
Summary of Changes
If a replacement string is used, but no 'quicktask' is defined
$params->get('menu-quicktask')will returnnullwhich triggers:Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in administrator/components/com_menus/src/Helper/MenusHelper.php on line 894Actual result BEFORE applying this Pull Request
deprecation warning with PHP 8.1+
Expected result AFTER applying this Pull Request
No deprecation warning with PHP 8.1+
Link to documentations
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed