[5.0] Adding joomla/language dependency #40432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
….0-language # Conflicts: # composer.lock
|
I would like to merge it but the deprecation message is not possible (deprecate in 5 remove in 6, if it should be removed in 6 you have to deprecate it in 4.4) and I miss the manual.joomla.org pr |
….0-language # Conflicts: # composer.lock
|
The deprecations will be handled in #40727. |
|
Thanks Documentation: joomla/Manual@dc9587a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds the Joomla framework language package as a dependency. This is a preparation for using the Filter package of the framework instead of the CMS, which again is a preparation to using the Input package of the framework instead of the CMS one. Overall, we want to reduce duplicate code. I see the irony, that this introduces a big block of duplicated code for now.
Yes, the classes in the CMS are currently sometimes further ahead than the framework ones, containing additional features, however the framework classes generally have higher quality code, better code coverage and have been properly capsulated. That is the reason why we should switch over to those framework packages.
While this PR allows us to deprecate the Filter CMS classes and Input CMS classes, and switch core code over to the framework classes, we still will have to synchronize the language framework package and the CMS language classes.
This also deprecates the methods in the Language class which are related to com_search.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Commit
No documentation changes for manual.joomla.org needed