[4.4] Deprecating com_search methods in Joomla\CMS\Language\Language #40727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Thanks. Can you make a manual pr as well? |
|
Done. |
|
Thanks! |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 26, 2024
joomla#40727 deprecated various search methods in `libraries/src/Language/Language.php` This PR completes that PR by deprecating their use in the localise.php file
4 tasks
LadySolveig
pushed a commit
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
com_search has been removed from the core and will not be supported in Joomla 6.0 anymore. Thus we should deprecate these methods.
Testing Instructions
Codereview
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Adding deprecations for com_search-specific Language methods Manual#123
No documentation changes for manual.joomla.org needed