New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Guided Tours disabled plugin #40449
Conversation
I tested this successful but I am not sure about the message. How about directing the user where and what to do? Why full functionality? If you say you have to enable the plugin to display the module, the user can be confused if the module is then still not displayed because the module could be unpublished too. Or we have to check for both to be enabled and published. Hope it makes sense. |
You are welcome to add additional changes |
So what do you think, does it make sense? Is it correct english? "The Guided Tours System Plugin is disabled. Please enable the “Guided Tours System Plugin” in System » Plugins for full functionality." |
I would either keep it as is or enhance it by direcvtly linking to the plugin manager as is done with the redirect and smart search but the code in guidedtours was too different for me to do that. |
administrator/components/com_guidedtours/src/Controller/DisplayController.php
Outdated
Show resolved
Hide resolved
I have tested this item ✅ successfully on 72c5e1f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40449. |
I have tested this item ✅ successfully on 72c5e1f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40449. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40449. |
Thanks |
Thanks! |
Новое в Joomla 4.3.3 Stable * joomla/joomla-cms#40637 + * joomla/joomla-cms#40698 - (исправлено ранее) * joomla/joomla-cms#40716 - (только для en-GB) * joomla/joomla-cms#40732 + * joomla/joomla-cms#40607 + Новое в Joomla 4.3.4 Stable * joomla/joomla-cms#40449 + * joomla/joomla-cms#40119 + * joomla/joomla-cms#40297 + * "Вход на сайт", но "Выход из системы" - разброс формулировок исправлен на термин "система", подразумевая именно вход/авторизацию пользователя, а не просто серфинг страницы сайта без авторизации * Другие мелкие исправления
Summary of Changes
If the system guided tours plugin is disabled then the tours do not work
This simple pr adds a notice in the component if the plugin is disabled
Testing Instructions
Disable the system plugin for guided tours
Open the guided tours component
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed