Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Guided Tours disabled plugin #40449

Merged
merged 5 commits into from Jul 26, 2023

Conversation

brianteeman
Copy link
Contributor

Summary of Changes

If the system guided tours plugin is disabled then the tours do not work

This simple pr adds a notice in the component if the plugin is disabled

Testing Instructions

Disable the system plugin for guided tours
Open the guided tours component

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.3-dev labels Apr 21, 2023
@coolcat-creations
Copy link
Contributor

I tested this successful but I am not sure about the message.

How about directing the user where and what to do?
So instead: The Guided Tours System Plugin is disabled. The Guided Tours module will not be displayed if this is not enabled.
Something like: Please enable the "The Guided Tours System Plugin" in System » Plugins for full functionality.

Why full functionality? If you say you have to enable the plugin to display the module, the user can be confused if the module is then still not displayed because the module could be unpublished too. Or we have to check for both to be enabled and published.

Hope it makes sense.

@brianteeman
Copy link
Contributor Author

You are welcome to add additional changes

@coolcat-creations
Copy link
Contributor

So what do you think, does it make sense? Is it correct english?

"The Guided Tours System Plugin is disabled. Please enable the “Guided Tours System Plugin” in System » Plugins for full functionality."

@brianteeman
Copy link
Contributor Author

I would either keep it as is or enhance it by direcvtly linking to the plugin manager as is done with the redirect and smart search but the code in guidedtours was too different for me to do that.

@MojoMojosoup
Copy link

I have tested this item ✅ successfully on 72c5e1f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40449.

@khu5h1
Copy link
Contributor

khu5h1 commented Jul 7, 2023

I have tested this item ✅ successfully on 72c5e1f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40449.

@alikon
Copy link
Contributor

alikon commented Jul 7, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40449.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 7, 2023
@wilsonge wilsonge enabled auto-merge (squash) July 26, 2023 17:32
@obuisard obuisard added this to the Joomla! 4.3.4 milestone Jul 26, 2023
@wilsonge wilsonge merged commit 5ce99f2 into joomla:4.3-dev Jul 26, 2023
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 26, 2023
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the 4.3-dev-friday_2 branch July 26, 2023 19:12
@wilsonge
Copy link
Contributor

Thanks!

heelc29 added a commit to heelc29/joomla that referenced this pull request Jul 27, 2023
GeraintEdwards pushed a commit to GeraintEdwards/joomla-cms that referenced this pull request Aug 14, 2023
Kostelano added a commit to JPathRu/localisation that referenced this pull request Aug 20, 2023
Новое в Joomla 4.3.3 Stable
* joomla/joomla-cms#40637 +
* joomla/joomla-cms#40698 - (исправлено ранее)
* joomla/joomla-cms#40716 - (только для en-GB)
* joomla/joomla-cms#40732 +
* joomla/joomla-cms#40607 +

Новое в Joomla 4.3.4 Stable
* joomla/joomla-cms#40449 +
* joomla/joomla-cms#40119 +
* joomla/joomla-cms#40297 +
* "Вход на сайт", но "Выход из системы" - разброс формулировок исправлен на термин "система", подразумевая именно вход/авторизацию пользователя, а не просто серфинг страницы сайта без авторизации
* Другие мелкие исправления
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-4.3-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet