Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Mobile pagination Cassiopeia #40620

Closed
wants to merge 2 commits into from

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #32674 #37711 and many more reports

Summary of Changes

Prevent the pagination going "off-screen" on small devices

Testing Instructions

This PR is an scss change so either apply the PR and then npm run build:css or install a prebuilt package
Then create a menu item to a list of all articles in a category making sure that you have a lot of articles to force the pagination. Hint if you set the list limit to 5 you need less articles

Actual result BEFORE applying this Pull Request

The pagination forces the screen to be much wider than the device
image

Expected result AFTER applying this Pull Request

The navigation bar is truncated as shown in the screenshot
image

If accepted I will make the same change for the same problem in atum

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels May 17, 2023
@brianteeman
Copy link
Contributor Author

@hans2103 I would be grateful if you could check my scss - it works but perhaps could be improved?

@hans2103
Copy link
Contributor

While testing I stumbled upon another issue... why is there a float on paragraph with className com-content-category-blog__counter?

Scherm­afbeelding 2023-05-17 om 16 08 41

Out of scope for this issue... but just noticing it to make an issue later. ;-)

@hans2103
Copy link
Contributor

@brianteeman Testing your PR. In your example you are only going to display the first 4 and last 4 list items of the pagination. But when you are on page 3 - 8 you have no visible clue that you are. I think you should have a visible clue on what page number you are. Therefor the active page should be visible.

@richard67
Copy link
Member

@brianteeman Could you fix the code style errors reported here https://ci.joomla.org/joomla/joomla-cms/65841/1/28 ? Thanks in advance.

@brianteeman
Copy link
Contributor Author

Sorry this is clearly not correct

@brianteeman brianteeman deleted the pagination-mobile branch October 18, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants