Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Move from static Text access to the text function of the plugin #41092

Closed
wants to merge 5 commits into from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Jun 30, 2023

Summary of Changes

The $this->text() function should be used in plugin template files to translate strings. This eliminates the static use of Text::_. When template files start to use functionality from the current context it will allow them to be reusable.

Testing Instructions

  • Create an url custom field
  • Open TinyMCE by editing an article
  • Check if the strings in the editor buttons are translated

Actual result BEFORE applying this Pull Request

All strings are translated.

Expected result AFTER applying this Pull Request

All strings are translated.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo laoneo mentioned this pull request Jun 30, 2023
4 tasks
@laoneo laoneo changed the title Move from static Text access to the text function of the plugin [5.0] Move from static Text access to the text function of the plugin Jun 30, 2023
@richard67
Copy link
Member

@laoneo System tests are failing, and I think it could be related to this PR.

@laoneo
Copy link
Member Author

laoneo commented Aug 17, 2023

Closing in favor of #41384.

@laoneo laoneo closed this Aug 17, 2023
@laoneo laoneo deleted the plugins/text/replace branch August 17, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants