Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Smart Search: Fix index button in emptystate #41094

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jun 30, 2023

Pull Request for Issue #41089.

Summary of Changes

When in Joomla 5.0 the index is empty, the button in the emptystate layout references the wrong toolbar button to start the indexing process.

Testing Instructions

  1. Clear your index.
  2. Click on the button "Start the Indexer"

Actual result BEFORE applying this Pull Request

Nothing happens except for an error in the JS console.

Expected result AFTER applying this Pull Request

The modal of the indexer pops up and content is indexed, similar to clicking the toolbar button "index" at the top.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Jun 30, 2023

I have tested this item ✅ successfully on 8fbf67b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41094.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 8fbf67b

Tested with success. I can also confirm that the issue does not exist in 4.3-dev and 4.4-dev, only in 5.0-dev, as the button name in the view has been changed to the right name in 5.0-dev only due to b/c reasons.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41094.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41094.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 30, 2023
@richard67 richard67 added the bug label Jun 30, 2023
@HLeithner HLeithner merged commit 2fa7185 into joomla:5.0-dev Jul 1, 2023
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 1, 2023
@HLeithner
Copy link
Member

thanks

@Hackwar Hackwar deleted the 5.0-finder-emptystate branch March 22, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants