[5.0] Joomla Update: Cleanup of file writes in UpdateModel

[Hackwar]

Summary of Changes

In UpdateModel of the Joomla Update component, we are doing some write operations on the filesystem as preparation before unpacking the update package. This code contains some unnecessary steps and is missing error handling.

Going through the changes one by one:

• With the switch from the CMS to the framework File package, the File::delete() now checks if the file exists first and otherwise throws an exception. Thus we either have to wrap it in is_file() or catch the exception.
• We then try to write the update package file to our filesystem, but we never check if that was successfull.
• Trying to delete the update.php, File::delete() does the same as unlink() now and already does the opcache invalidation.
• Since Joomla 4 doesn't have the FTP layer anymore, we can simplify the last codeblock greatly.

Testing Instructions

This code change resulted from manual code review and is not based on a specific error condition. Simply said, updating Joomla should still work the same as before.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[richard67]

• With the switch from the CMS to the framework File package, the File::delete() now checks if the file exists first and otherwise throws an exception. Thus we either have to wrap it in is_file() or catch the exception.

@Hackwar I think the same applies to deleting files and folders on update in script.php. Of course something for another PR. Is that right?

Update: I see we have already an is_file check there for the files so that should be ok. Not sure about the folders, will check later.

[HLeithner]

Should be easier to test this when it's in nightlies