Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Update FtpClient.php #41111

Merged
merged 6 commits into from
Aug 21, 2023
Merged

[4.4] Update FtpClient.php #41111

merged 6 commits into from
Aug 21, 2023

Conversation

stell
Copy link
Contributor

@stell stell commented Jul 4, 2023

PHP 8.1

Pull Request for Issue #40438.

Summary of Changes

Existing code that relied on is_resource function now needs to account for the new FTP\Connection class objects in PHP 8.1.

Testing Instructions

see #40438.

Actual result BEFORE applying this Pull Request

fail

Expected result AFTER applying this Pull Request

works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

@stell Will this still work on PHP versions older than 8.1? If not, the PR cannot be used for 4.3 or 4.4 and has to be made for 5.0, i.e. the base branch needs to be changed to 5.0-dev. With Joomla 4.3 and 4.4 we still have to support older PHP versions, with Joomla 5 the minimum required PHP version will be 8.1.

removed comments
stell added 2 commits July 4, 2023 20:32
Removed spaces
fixed boolean checks
@stell
Copy link
Contributor Author

stell commented Jul 4, 2023

@richard67 Checking boolean works for FTP Buffer (< 8.1) and FTP\Connection(> 8.0) as far i can see.

@HLeithner
Copy link
Member

It' something for j4.4 but please check if is_resource or object and instance of the ftp class.

@HLeithner HLeithner changed the title Update FtpClient.php [4.4] Update FtpClient.php Jul 26, 2023
@HLeithner HLeithner changed the base branch from 4.3-dev to 4.4-dev July 26, 2023 06:57
@laoneo
Copy link
Member

laoneo commented Aug 17, 2023

I have tested this item ✅ successfully on 0d75fae

Tested on PHP 8.2 and 7.4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41111.

@MacJoom MacJoom enabled auto-merge (squash) August 19, 2023 14:21
@MacJoom MacJoom disabled auto-merge August 20, 2023 15:57
@MacJoom MacJoom added this to the Joomla! 4.4.0 milestone Aug 21, 2023
@MacJoom MacJoom merged commit f622737 into joomla:4.4-dev Aug 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants