Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Record currentStepId in sessionStorage when responding to an interaction #41155

Merged
merged 3 commits into from Jul 18, 2023

Conversation

GeraintEdwards
Copy link
Contributor

@GeraintEdwards GeraintEdwards commented Jul 13, 2023

Please see equivalent PR for Joomla 5 at #40776

Pull Request for Issue # .

Summary of Changes

Change handling of 'button' interactive type to respond to the button click rather than immediately executing.

This execution happens at the start of the tour and not when the step has actually been reached and so the modal setup ends up being called twice. As a result other steps with interactive actions e.g. checkboxes or text input fields cannot be interacted with.

Testing Instructions

Create a tour as per following screenshots - a JSON import is attached if you have implemented the tours import/export PR #40645

backdropProblemTour.zip

Screenshot 2023-06-15 at 13-01-58 Guided Tours Edit Tour - Joomla Tours - Administration

Screenshot 2023-06-15 at 13-02-20 Guided Tours Edit Step - Joomla Tours - Administration

Screenshot 2023-06-15 at 13-02-29 Guided Tours Edit Step - Joomla Tours - Administration

Screenshot 2023-06-15 at 13-02-38 Guided Tours Edit Step - Joomla Tours - Administration

Screenshot 2023-06-15 at 13-02-46 Guided Tours Edit Step - Joomla Tours - Administration

Screenshot 2023-06-15 at 13-02-56 Guided Tours Edit Step - Joomla Tours - Administration

Unpublish steps 3 and 4 so that you have this as an overview

Screenshot 2023-06-15 at 13-11-57 Guided Tour Guided Tours Modal Backdrop Problem - Joomla Tours - Administration

Now run the tour

Actual result BEFORE applying this Pull Request

At step 2 you have a double backdrop and can't interact with the checkbox

Screenshot 2023-06-15 at 13-12-36 Articles Categories - Joomla Tours - Administration

If you enable steps 3 and 4 it behaves even worse

Screenshot 2023-06-15 at 13-13-54 Articles Categories - Joomla Tours - Administration

and if you proceed with clicking the rebuild button you get stuck in a loop.

Expected result AFTER applying this Pull Request

Screenshot 2023-06-15 at 13-14-59 Articles Categories - Joomla Tours - Administration

You also don't get a loop on the rebuild button action step

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [x ] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [ x] No documentation changes for manual.joomla.org needed

…ive button - the button may cause a page redirect or form submission

Progreed to next step when the button is clicked and not immediately - otherwise then the tour is being set up you can end up with a double modal back drop being created
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Jul 13, 2023
@GeraintEdwards GeraintEdwards marked this pull request as ready for review July 13, 2023 15:44
@sdwjoomla
Copy link
Contributor

sdwjoomla commented Jul 14, 2023

I have tested this item ✅ successfully on a40e388


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41155.
2023-07-14_16-20-48

@obuisard obuisard added this to the Joomla! 4.3.4 milestone Jul 15, 2023
@khu5h1
Copy link
Contributor

khu5h1 commented Jul 16, 2023

I have tested this item ✅ successfully on a40e388


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41155.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 4.3.4 milestone Jul 16, 2023
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41155.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 16, 2023
@richard67 richard67 added the bug label Jul 16, 2023
@richard67 richard67 added this to the Joomla! 4.3.4 milestone Jul 16, 2023
@brianteeman
Copy link
Contributor

What happens when you navigate backwards?

@richard67
Copy link
Member

What happens when you navigate backwards?

@brianteeman You mean with the „back“ button of the browser?

@brianteeman
Copy link
Contributor

no I mean the back button in the tour

@GeraintEdwards
Copy link
Contributor Author

no I mean the back button in the tour

It is well behaved in my tests - did you see a problem? Can you should how to recreate it and I'll investigate.

p.s. Another of my PRs (for Joomla 5 at least) resolves the problem with orphan steps when you bit the browser back button e.g. in the middle of the article creation tour.

@brianteeman
Copy link
Contributor

It is well behaved in my tests - did you see a problem? Can you should how to recreate it and I'll investigate.

didnt test it just wanted to makie sure it was handled

@obuisard obuisard merged commit 63e43cf into joomla:4.3-dev Jul 18, 2023
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 18, 2023
@obuisard
Copy link
Contributor

Thanks Geraint @GeraintEdwards for the PR!

GeraintEdwards added a commit to GeraintEdwards/joomla-cms that referenced this pull request Aug 14, 2023
…ive button - the button may cause a page redirect or form submission (joomla#41155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants