New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Record currentStepId in sessionStorage when responding to an interaction #41155
Conversation
…ive button - the button may cause a page redirect or form submission Progreed to next step when the button is clicked and not immediately - otherwise then the tour is being set up you can end up with a double modal back drop being created
I have tested this item ✅ successfully on a40e388 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41155. |
I have tested this item ✅ successfully on a40e388 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41155. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41155. |
What happens when you navigate backwards? |
@brianteeman You mean with the „back“ button of the browser? |
no I mean the back button in the tour |
It is well behaved in my tests - did you see a problem? Can you should how to recreate it and I'll investigate. p.s. Another of my PRs (for Joomla 5 at least) resolves the problem with orphan steps when you bit the browser back button e.g. in the middle of the article creation tour. |
didnt test it just wanted to makie sure it was handled |
Thanks Geraint @GeraintEdwards for the PR! |
…ive button - the button may cause a page redirect or form submission (joomla#41155)
Please see equivalent PR for Joomla 5 at #40776
Pull Request for Issue # .
Summary of Changes
Change handling of 'button' interactive type to respond to the button click rather than immediately executing.
This execution happens at the start of the tour and not when the step has actually been reached and so the modal setup ends up being called twice. As a result other steps with interactive actions e.g. checkboxes or text input fields cannot be interacted with.
Testing Instructions
Create a tour as per following screenshots - a JSON import is attached if you have implemented the tours import/export PR #40645
backdropProblemTour.zip
Unpublish steps 3 and 4 so that you have this as an overview
Now run the tour
Actual result BEFORE applying this Pull Request
At step 2 you have a double backdrop and can't interact with the checkbox
If you enable steps 3 and 4 it behaves even worse
and if you proceed with clicking the rebuild button you get stuck in a loop.
Expected result AFTER applying this Pull Request
You also don't get a loop on the rebuild button action step
Link to documentations
Please select:
Documentation link for docs.joomla.org:
[x ] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[ x] No documentation changes for manual.joomla.org needed