Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#34077] Problem if feed contains only a few entries #4125

Merged
merged 1 commit into from Sep 18, 2014
Merged

[#34077] Problem if feed contains only a few entries #4125

merged 1 commit into from Sep 18, 2014

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Aug 17, 2014

How to test

  1. create new newsfeed with https://jobwelt.telekom.com/jpapps/n/ext/rs/?query=t&keywords=TSIonsiteHH
  2. Tab "Display" --> Number of Articles = 5 (or simple more than your newsfeed has)
  3. create a menu entry for the newsfeed
  4. Access the newsfeed on the frontend.
  5. See the errors:
"Notice: Undefined offset: 1 in \htdocs\libraries\joomla\feed\feed.php on line 201"

and

"Notice: Trying to get property of non-object in \htdocs\components\com_newsfeeds\views\newsfeed\tmpl\default.php on line 109".
  1. apply this patch e.g. with com_patchtester.
    Documentation: http://docs.joomla.org/Component_Patchtester_for_Testers
    Download: https://github.com/mbabker/patchtester/releases
  2. See that the errors are gone.

Tracker

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=34077

@zero-24 zero-24 changed the title Problem if feed contains only a few entries [#34077] Problem if feed contains only a few entries Aug 17, 2014
@JerryChr-zz
Copy link

Tested succesfully and got the notices as seen on my attached image:
screen shot 2014-09-15 at 16 19 24

Applied this patch #4125 and the notices did go away.
screen shot 2014-09-15 at 16 21 02


This comment was created with the J!Tracker Application at http://issues.joomla.org/.

@zero-24
Copy link
Contributor Author

zero-24 commented Sep 16, 2014

thanks @JerryChr one more tester for RTC

@b2z
Copy link
Member

b2z commented Sep 17, 2014

@test ok

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

@zero-24
Copy link
Contributor Author

zero-24 commented Sep 17, 2014

thanks @b2z moving to RTC

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

@infograf768 infograf768 added the RTC This Pull Request is Ready To Commit label Sep 17, 2014
infograf768 added a commit that referenced this pull request Sep 18, 2014
[#34077] Problem if feed contains only a few entries
@infograf768 infograf768 merged commit 7568965 into joomla:staging Sep 18, 2014
@infograf768
Copy link
Member

thanks

@zero-24 zero-24 deleted the patch-3 branch September 18, 2014 07:34
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants