Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Every fieldset must have a legend
Every input/select must have a label
thanks to @wilsonge for spotting this
Testing Instructions
Create a menutype for archive articles
In the Archive tab set the Filter Field to show
Display the menu in the front end
Existing language strings have been used so there is no translation required
Expected result BEFORE applying this Pull Request
Visually there is a small change as there is now a gab between the title and filter rows
Non-visually there is now a legend and labels for all the selects
Passes accessibility tests
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed