Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Content Archive a11y #41329

Merged
merged 2 commits into from Aug 7, 2023
Merged

Conversation

brianteeman
Copy link
Contributor

Summary of Changes

Every fieldset must have a legend
Every input/select must have a label

thanks to @wilsonge for spotting this

Testing Instructions

Create a menutype for archive articles
In the Archive tab set the Filter Field to show
Display the menu in the front end

Existing language strings have been used so there is no translation required

Expected result BEFORE applying this Pull Request

Visually there is a small change as there is now a gab between the title and filter rows
Non-visually there is now a legend and labels for all the selects
Passes accessibility tests

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

I have tested this item ✅ successfully on 41811b4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41329.

@richard67
Copy link
Member

Can be tested with the built-in accessibility check of Firefox developer tools. Before applying the PR there are also errors about missing labels, after applying the PR only a contrast issue is remaining. Markup inspection looks right, too. The "for" of the labels fits to the IDs of the selects.

@richard67
Copy link
Member

P.S.: Testing sample data can be used on a development version to get the archived article and the menu item. It just needs to set the filter to be shown as described in the instructions.

@Quy
Copy link
Contributor

Quy commented Aug 7, 2023

I have tested this item ✅ successfully on 41811b4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41329.

@Quy
Copy link
Contributor

Quy commented Aug 7, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41329.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 7, 2023
@Quy Quy added this to the Joomla! 4.3.4 milestone Aug 7, 2023
@obuisard obuisard added the bug label Aug 7, 2023
@obuisard obuisard merged commit de6a50e into joomla:4.3-dev Aug 7, 2023
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 7, 2023
@obuisard
Copy link
Contributor

obuisard commented Aug 7, 2023

Thank you Brian @brianteeman for the PR.

@brianteeman brianteeman deleted the archive-a11y branch August 7, 2023 17:19
GeraintEdwards pushed a commit to GeraintEdwards/joomla-cms that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants