Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Filtering for non-core extensions closes the searchbar #41383

Merged
merged 2 commits into from Aug 26, 2023

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Aug 17, 2023

Pull Request for Issue #41382 .

Summary of Changes

added core to filter

Testing Instructions

open /administrator/index.php?option=com_installer&view=manage
Select the last filter "non-core extensions"

Actual result BEFORE applying this Pull Request

page releoad
search bar is closed

Expected result AFTER applying this Pull Request

page releoad
search bar is open

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Aug 17, 2023

I have tested this item ✅ successfully on dc60c9c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41383.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on dc60c9c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41383.

@Quy
Copy link
Contributor

Quy commented Aug 17, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41383.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 17, 2023
@richard67 richard67 added the bug label Aug 22, 2023
@rachelwalraven
Copy link

On Joomla 4.3.5 Dev with PHP 8.1.22 and using Chrome I do not have the issue. When selecting the non-core-extensions the filteroption bar stays open.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41383.

@HLeithner HLeithner merged commit 385b8ff into joomla:4.3-dev Aug 26, 2023
3 checks passed
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 26, 2023
@alikon alikon deleted the alikon-patch-1-1 branch August 27, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants