[5.0] SQL fix and update scripts for PR #41259 #41417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes all usages of JComponentHelper to \Joomla\CMS\Component\ComponentHelper. Additionally an exception is thrown when JComponehtHelper is used as filter but is not resolvable. Existing entries have to converted manually or per migration script.
4 tasks
This reverts commit 95d8972.
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
|
@laoneo Why did you close this PR? The new update SQL scripts are missing in Harald's PR. |
|
Rebased to 5.0-dev after PR #41259 has been merged. |
|
I have tested this item ✅ successfully on 64883f4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41417. |
|
@laoneo Have you tested with both MySQL and PostgreSQL? Or only MySQL? |
|
thanks richard and allon |
|
Only mysql |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up Pull Request (PR) for PR #41259 .
Summary of Changes
Add update SQL scripts for migrating the filter parameters of relevant core field plugins and the fieldparams of relevant custom fields on update.
Testing Instructions
Have a clean 5.0.0-alpha3 or previous 5.0.0 alpha version or a 4.4-alpha3.
Create a few custom fields of types "text", "textarea" or "editor" for articles, and for some of these fields use the "Text" filter, for some use the filter from the plugin and for others use some other filter.
Now update to a new package build on the 5.0-dev branch for the actual result, or update to the patched package or custom update URL created by Drone for this PR for the expected result.
Then check the filter parameter of the fields plugins in the
#__extensionstable.Then check the filter parameter of the field's fieldparams plugins in the
#__fieldstable.Finally create an article using the custom fields created before the update and save that article.
Actual result BEFORE applying this Pull Request
After an update, the parameters and fieldparams have not been migrated.
Expected result AFTER applying this Pull Request
After an update, the parameters and fieldparams have been migrated.
Saving the article with the custom fields works.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed