-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix calendar positioning #41477
Fix calendar positioning #41477
Conversation
I have tested this item ✅ successfully on 5765385 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41477. |
@magnussinger Does this also solve the other 2 issues #38443 and #38346 ? |
I have tested this item ✅ successfully on 5765385 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41477. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41477. |
I have tested this item ✅ successfully on 5765385 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41477. |
|
No as this is just a fix for the general calendar positioning, the other special cases might need additional PRs? |
Thank you Magnus @magnussinger for the PR! |
* fix calendar positioning (#41477) * Update joomla-field-media.w-c.es6.js (#41361) * Fixing md5 Deprecation in document.php (#39880) * modal field check for danger alert (#39173) * fix (#41138) * [4.x] Cassiopeia Install SQL (#37389) * Fix/showon (#37451) * Bugfix for Issue #38599 - Smart Search indexing macros from articles (#38998) * [4,3] joomla alert icons (#39312) * Update StyleModel.php (#40665) * Update Query.php (#40687) * remove hitcount variable from uri after voting (#41474) * Fix deprecated message in categories when extension is empty (#40604) * Re-add minus to allowed filenames in com_templates (#41369) * Invalid delete of all content articles from smart search index (#41288) * [4][cli] schema update check (#40468) * Tags: Don't put NULL into trim() (#41509) Co-authored-by: Quy <quy@nomonkeybiz.com> * [4] Add multilanguage filter taxonomy rows in com_finder advanced filters (#41470) * Fix taxonomy filter options * refactor rest of query to prepared statements --------- Co-authored-by: Quy <quy@nomonkeybiz.com> * Check if the pre update check box actually exists (#41467) * Allow onValidateContact plugin to show error message (#37540) * [4.4] Backward compatibility handling for plugins that setting the result directly (#41525) * Backward compatibility handling for plugins that setting the result directly. * Update libraries/src/Event/AbstractImmutableEvent.php Co-authored-by: Brian Teeman <brian@teeman.net> --------- * Tests for com_privacy consent on user site (#41529) * Tests for com_privacy consent on user site * Allow ability to enable extension in tests to prevent errors * remove paramater not needed * Added fixes to stop errors in drone build * Added fixes to stop errors in drone build * Added fixes to stop errors in drone build * [4.4] system test for com_installer (#41483) * system test for com_installer * cs * Missing System Tests in #41362 (#41479) * Update Categories.cy.js * Update Categories.cy.js * Update Categories.cy.js * Update Categories.cy.js * Update Categories.cy.js * Update Categories.cy.js added spaces and semicolons * Update Categories.cy.js Missing spaces and semicolons * Update Categories.cy.js Missing spaces and semicolons * Update Categories.cy.js Missing spaces and semicolons * Update Categories.cy.js removed tabs * Update Categories.cy.js Removed tabs * Update Categories.cy.js Removed tabs * Update Categories.cy.js Removed tabs * Update Language.php (#41353) * Filter for special characters that fail sending test mail (#41469) * Backporting event changes (#41484) Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> * api tests for endpoints for com_privacy consent (#41544) * Show the plugin name in the update screen (#41537) * Show the plugin name in the update screen * cs --------- * Replace the special characters in site name for mail templates (#41582) * Updates the dependencies (#41538) * Updating dependencies * Major update cypress * Thanks for the reminder @brianteeman * Composer * weekend updates * Update dependencies * Update incompatible HTML file --------- Co-authored-by: Magnus Singer <magnussinger@icloud.com> Co-authored-by: Dimitris Grammatikogiannis <d.grammatiko@gmail.com> Co-authored-by: Crystal Dionysopoulos <9141288+crystalenka@users.noreply.github.com> Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> Co-authored-by: Denitz <197527+Denitz@users.noreply.github.com> Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: toroworx <toroworx@users.noreply.github.com> Co-authored-by: Martin Carl Kopp <6154099+MacJoom@users.noreply.github.com> Co-authored-by: Jonathan Brain <3941269+BrainforgeUK@users.noreply.github.com> Co-authored-by: Olivier Buisard <olivier.buisard@simplifyyourweb.com> Co-authored-by: Christiane Maier-Stadtherr <dev@chmst.de> Co-authored-by: Manuel Huber <ManuelHu@users.noreply.github.com> Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com> Co-authored-by: Hannes Papenberg <info@joomlager.de> Co-authored-by: Quy <quy@nomonkeybiz.com> Co-authored-by: David Jardin <d.jardin@djumla.de> Co-authored-by: beefcakefu <103491197+beefcakefu@users.noreply.github.com> Co-authored-by: Fedir Zinchuk <getthesite@gmail.com> Co-authored-by: andyforrest <46865032+andyforrest@users.noreply.github.com>
Pull Request for Issue #40577.
Summary of Changes
Depending on the scroll position of the page, the calendar gets displayed above or below the field, even when the scroll position changes
Testing Instructions
Open a calendar, scroll on the page and open the calendar again. Depending on the scroll position, it should change if the calendar opens above or below the field
Actual result BEFORE applying this Pull Request
Sometimes, the calendar got stuck above or below the field when you changed the scroll position
Expected result AFTER applying this Pull Request
It now gets changed when you scroll
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed