Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Fix events with non required arguments: AfterPurgeEvent::setSubject(): Argument 1 must be of type string, null given #41620

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Sep 6, 2023

Pull Request for Issue # .

Summary of Changes

reshapeArguments should not be called when there no required arguments, and arguments is empty.

Fix error AfterPurgeEvent::setSubject(): Argument #1 ($value) must be of type string, null given
When trying to clean all cache, and similar cases

Testing Instructions

Go to Maintenance: clear cache.
And click "Delete all"

Actual result BEFORE applying this Pull Request

And error

Expected result AFTER applying this Pull Request

No error

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Sep 6, 2023

I have tested this item ✅ successfully on 5372b6e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41620.

@HLeithner HLeithner merged commit daa079c into joomla:5.0-dev Sep 6, 2023
1 of 2 checks passed
@Fedik Fedik deleted the event-fx-ix-non-required-arg branch September 7, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants