Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Fix info and notice alert colors #41815

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

wilsonge
Copy link
Contributor

Pull Request for Issue #41813 .

Summary of Changes

Changes the info color for dark mode and removes an unused border parameter.

Testing Instructions

In the database maintaince view check the color is now legible and a11y compliant

Actual result BEFORE applying this Pull Request

maintenance-database

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Sep 19, 2023
@Quy
Copy link
Contributor

Quy commented Sep 19, 2023

Please see the close (X) icon where it has a white outline.

@wilsonge
Copy link
Contributor Author

Fixed

@richard67
Copy link
Member

@wilsonge Could you fix the scss-cs error reported in drone?

build/media_source/templates/administrator/atum/scss/vendor/joomla-custom-elements/joomla-alert.scss
10s
8 133:5 ✖ Expected "text-shadow" to come before "opacity" order/properties-order

@wilsonge
Copy link
Contributor Author

Done

@Quy
Copy link
Contributor

Quy commented Sep 19, 2023

I have tested this item ✅ successfully on 2562199


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41815.

@HLeithner HLeithner merged commit 1b9e141 into joomla:5.0-dev Sep 20, 2023
3 of 4 checks passed
@HLeithner
Copy link
Member

thanks

@wilsonge wilsonge added this to the Joomla! 5.0 milestone Sep 20, 2023
@wilsonge wilsonge deleted the fix/info-alert-color branch September 20, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants