[5.0] Select Schedule Task css

[brianteeman]

The select task view is the same as the select module view except it uses its own css file with invalid css.

This PR changes that so that it uses an scss file in exactly the same way as com_modules. This also removes the invalid css and makes it more maintainable. There will be no visible change

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org: will be added when merged

• No documentation changes for manual.joomla.org needed

[HLeithner]

removing the asset from the joomla.asset.json could lead to an exception if 3rd party uses it. since we don't have a policy for it. Please move this entry to the b/c plugin with an empty file reference and update the manual b/c / deprecation section.

[brianteeman]

removing the asset from the joomla.asset.json could lead to an exception if 3rd party uses it. since we don't have a policy for it. Please move this entry to the b/c plugin with an empty file reference and update the manual b/c / deprecation section.

sorry - not sure exactly what you are asking for here

[HLeithner]

more or like a copy of that what the compat plugin does for the es5 assets. new json file with the removed parts from this pr and loading the new json file when the es5 assets are loaded

[brianteeman]

sorry I think I understand what you mean but I dont know what to put in place of the xxxxxxxxxxx

        /**
         * Load the es5 assets stubs, they are needed if an extension
         * directly uses a core es5 asset which has no function in Joomla 5+
         * and only provides an empty asset to not throw an exception
         */
        if ($this->params->get('es5_assets', '1')) {
            $event->getDocument()
                ->getWebAssetManager()
                ->getRegistry()
                ->addRegistryFile('media/plg_behaviour_compat/es5.asset.json');
        }

        /**
         * Load the com_scheduler.admin-view-select-task-css stub asset, if an extension
         * directly used it - very unlikely - to an asset which has no function in Joomla 5+
         * and only provides an empty asset to not throw an exception
         */
        if ($this->params->get('***************', '1')) {
            $event->getDocument()
                ->getWebAssetManager()
                ->getRegistry()
                ->addRegistryFile('media/plg_behaviour_compat/**********.json');
        }

[richard67]

@brianteeman Shall I help with the merge conflicts?

[brianteeman]

@richard67 yes please - not in the right headspace today to resolve it

[brianteeman]

Any help with this would be appreciated as well #41871 (comment)

@wilsonge @HLeithner @richard67

[wilsonge]

I think like this

joomla-cms/plugins/behaviour/compat/src/Extension/Compat.php

Line 95 in ddcdb9e

if ($this->params->get('es5_assets', '1')) {

[richard67]

@brianteeman Conflicts resolved. With the other thing I don't know yet if I can help.

[richard67]

System tests will fail in Drone due to unrelated reasons, see #41938 .

[brianteeman]

thanks @richard67

@wilsonge yes I assumed that in my post just dont have a clue what to put in place of the xxxxxxxxxx in my code snippet

[wilsonge]

Create a new parameter in the plugin. Doesn't make sense to mix this with the existing es5 assets

[brianteeman]

thats what i am doing arent i? just need to know what to put instead of the xxxxxxxxxxx

/me confused

[wilsonge]

https://github.com/joomla/joomla-cms/blob/5.0-dev/plugins/behaviour/compat/compat.xml#L36-L47 new param in here to match and then pick a name. removed_assets seems reasonable and we can polyfill any others into the same param rather than doing a param per asset.

[brianteeman]

Hopefully I just got it right now. As soon as you mentioned the xml it started to click

[wilsonge]

Looks fine to me

[brianteeman]

thanks