Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] resolve todo image filter #41885

Merged

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Sep 23, 2023

Remove check for resource when we only support PHP 8

As we are now using php8 the TODO has been resolved and the code can be removed

See comment joomla#28694 (comment)
@brianteeman brianteeman changed the title 21 resolve todo image filter [5.0] resolve todo image filter Sep 23, 2023
@brianteeman brianteeman marked this pull request as ready for review September 26, 2023 18:14
@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:48
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@brianteeman brianteeman changed the title [5.0] resolve todo image filter [5.1] resolve todo image filter Sep 30, 2023
@Quy Quy removed the PR-5.0-dev label Sep 30, 2023
@Quy
Copy link
Contributor

Quy commented Nov 21, 2023

I have tested this item ✅ successfully on 9fda474


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41885.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 9fda474


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41885.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41885.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 23, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 4, 2023
@brianteeman
Copy link
Contributor Author

afaict its a different thing but i could be wrong. I was just following the information in the todo notice

@Razzo1987
Copy link
Contributor

Thanks @brianteeman, Let's do an internal check and I'll update you

@brianteeman
Copy link
Contributor Author

whichever you decide any changes to those files are beyond the scope of this PR and should be handled in their own pr as they are nothing to do with the title of this PR

@richard67 richard67 added the RTC This Pull Request is Ready To Commit label Dec 6, 2023
@LadySolveig LadySolveig merged commit ad71450 into joomla:5.1-dev Dec 6, 2023
2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 6, 2023
@LadySolveig
Copy link
Contributor

Thank you @brianteeman !

@LadySolveig LadySolveig added the RTC This Pull Request is Ready To Commit label Dec 6, 2023
@brianteeman brianteeman deleted the 21_resolve_todo_image_filter branch December 7, 2023 00:18
@Quy Quy removed the RTC This Pull Request is Ready To Commit label Dec 7, 2023
@Quy Quy added this to the Joomla! 5.1.0 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants