Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Unused imports #41980

Merged
merged 2 commits into from Feb 28, 2024
Merged

[5.1] Unused imports #41980

merged 2 commits into from Feb 28, 2024

Conversation

Denitz
Copy link
Contributor

@Denitz Denitz commented Sep 28, 2023

Summary of Changes

Remove unused PHP imports.

Testing Instructions

Apply patch.

Actual result BEFORE applying this Pull Request

Unused imports, see IDE warnings.

Expected result AFTER applying this Pull Request

No unused imports.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo
Copy link
Member

laoneo commented Sep 28, 2023

I'm wondering why the CS fixer is not detecting that one.

@alikon
Copy link
Contributor

alikon commented Sep 28, 2023

should be nice to have this check/fix in the pipeline
🍹

@HLeithner HLeithner changed the title [5.0] Unused imports [5.1] Unused imports Sep 30, 2023
@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:48
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@rdeutz
Copy link
Contributor

rdeutz commented Jan 11, 2024

LGTM, code review and checking a few files if it is correct

@rdeutz rdeutz added Maintainers Checked Used if the PR is conceptional useful PR-5.1-dev and removed PR-5.0-dev labels Jan 11, 2024
@Quy
Copy link
Contributor

Quy commented Feb 21, 2024

I have tested this item ✅ successfully on 0b1fb2c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41980.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 0b1fb2c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41980.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41980.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 24, 2024
@bembelimen bembelimen merged commit 7fdf520 into joomla:5.1-dev Feb 28, 2024
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 28, 2024
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Maintainers Checked Used if the PR is conceptional useful PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants