New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Dark Mode: MFA button #42085
[5.0] Dark Mode: MFA button #42085
Conversation
@wilsonge please review and we need a test |
Don't know if it matters or not but this changes the button to solid from an outline button in light and dark mode |
We probably do need to fix the outline color to match what the main button is. However it also doesn’t hurt to unify the styling across core (if we aren’t using the outline class elsewhere) |
rc2 is coming soon, which marks the end of non critical PRs. |
I have tested this item ✅ successfully on dae9e0f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42085. |
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42085. |
I have tested this item ✅ successfully on dae9e0f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42085. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42085. |
Thanks |
Partial Pull Request for Issue #41794.
Summary of Changes
Don't use outline button in order to be visible in dark mode.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request