Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Fix language association "clear" button #42098

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Oct 9, 2023

Pull Request for Issue #42087 (comment) .

Summary of Changes

The language option has values separated with :, but the JS code was looking for |.

$options[$langCode]->value = $language->lang_code . ':' . $itemId . ':edit';

Testing Instructions

Run npm install
Edit association "side by side" for existing association,
Push "clear" button

Actual result BEFORE applying this Pull Request

Nothing happen

Expected result AFTER applying this Pull Request

Association removed

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

I have tested this item ✅ successfully on ce44c8c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42098.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Oct 9, 2023

I have tested this item ✅ successfully on ce44c8c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42098.

@joomla-cms-bot joomla-cms-bot removed Release Blocker NPM Resource Changed This Pull Request can't be tested by Patchtester bug PR-5.0-dev labels Oct 9, 2023
@alikon
Copy link
Contributor

alikon commented Oct 9, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42098.

@alikon alikon added Release Blocker NPM Resource Changed This Pull Request can't be tested by Patchtester bug PR-5.0-dev labels Oct 9, 2023
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42098.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 9, 2023
@HLeithner HLeithner merged commit b25524a into joomla:5.0-dev Oct 9, 2023
4 of 5 checks passed
@HLeithner
Copy link
Member

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 9, 2023
@richard67 richard67 added this to the Joomla! 5.0.0 milestone Oct 9, 2023
@Fedik Fedik deleted the fix42087-2 branch October 9, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants