Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Add proper error handling for public folder cli installation #42168

Merged
merged 2 commits into from Oct 20, 2023

Conversation

HLeithner
Copy link
Member

Summary of Changes

PublicFolderGeneratorHelper::createPublicFolder() returns void but throw exception

Testing Instructions

Install with cli and public folder

Actual result BEFORE applying this Pull Request

Execution stops after
Creating the public folder... (no new line)
reason for this is createPublicFolder() returns void which converts to false and ends with Command::FAILURE you Don't get a success message

Expected result AFTER applying this Pull Request

You get a success message after cli installation with public folder.

@HLeithner HLeithner mentioned this pull request Oct 18, 2023
2 tasks
@HLeithner HLeithner added the bug label Oct 18, 2023
@HLeithner HLeithner added this to the Joomla! 5.0.1 milestone Oct 18, 2023
@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 0c5a204


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42168.

1 similar comment
@bembelimen
Copy link
Contributor

I have tested this item ✅ successfully on 0c5a204


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42168.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.0.1 milestone Oct 20, 2023
@Quy
Copy link
Contributor

Quy commented Oct 20, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42168.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 20, 2023
@Quy Quy added this to the Joomla! 5.0.1 milestone Oct 20, 2023
@richard67 richard67 merged commit 4c799de into joomla:5.0-dev Oct 20, 2023
3 of 4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 20, 2023
@richard67
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants