[5.0] Add proper error handling for public folder cli installation #42168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
PublicFolderGeneratorHelper::createPublicFolder()
returns void but throw exceptionTesting Instructions
Install with cli and public folder
Actual result BEFORE applying this Pull Request
Execution stops after
Creating the public folder...
(no new line)reason for this is
createPublicFolder()
returns void which converts to false and ends withCommand::FAILURE
you Don't get a success messageExpected result AFTER applying this Pull Request
You get a success message after cli installation with public folder.