-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1][com_finder] check if finder content plugin is enabled #42299
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e8247ed
finder plugin enabled
alikon ed380ef
better check
alikon 4c7d253
link
alikon c693df9
lang
alikon 833c976
Merge branch '4.4-dev' into patch-18
alikon 4334e34
cs
alikon 203ae4a
Merge branch '4.4-dev' into patch-18
alikon dc42fd0
switch to 5.1
alikon 06b9f88
switch to 5.1
alikon a455afe
Merge branch '5.1-dev' into patch-18
alikon ddd8a15
conflict
alikon 578dd7d
Merge branch '5.1-dev' into patch-18
alikon 08fafcf
Merge branch '5.1-dev' into patch-18
alikon 4fc5c08
follow-#42447
alikon 623c759
follow-#42447
alikon 9615e31
follow-#42447
alikon 16735d4
follow-#42447
alikon 273a98d
Merge branch '5.1-dev' into patch-18
Hackwar File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,6 +111,7 @@ COM_FINDER_FILTERS_N_ITEMS_UNPUBLISHED="%d filters unpublished." | |
COM_FINDER_FILTERS_N_ITEMS_UNPUBLISHED_1="Filter unpublished." | ||
COM_FINDER_FILTERS_TABLE_CAPTION="Filters" | ||
COM_FINDER_FILTERS_TOOLBAR_TITLE="Smart Search: Search Filters" | ||
COM_FINDER_FINDER_PLUGINS="Smart Search Finder Plugins" | ||
alikon marked this conversation as resolved.
Show resolved
Hide resolved
|
||
COM_FINDER_HEADING_CHILDREN="Maps" | ||
COM_FINDER_HEADING_CREATED_BY="Created By" | ||
COM_FINDER_HEADING_CREATED_BY_ASC="Created By ascending" | ||
|
@@ -148,6 +149,7 @@ COM_FINDER_INDEX_NO_DATA="No content has been indexed." | |
COM_FINDER_INDEX_OPTIMISE_FINISHED="Optimisation finished." | ||
COM_FINDER_INDEX_PLUGIN_CONTENT_NOT_ENABLED="The Smart Search Content Plugin is disabled. Changes to content will not update the Smart Search index until the Plugin is enabled." | ||
COM_FINDER_INDEX_PLUGIN_CONTENT_NOT_ENABLED_LINK="The %s is disabled. Changes to content will not update the Smart Search index if you do not enable this plugin." | ||
COM_FINDER_INDEX_PLUGIN_FINDER_NOT_ENABLED_LINK="The %s are disabled. Changes to content will not update the Smart Search index if you do not enable these plugins." | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can't we make one (new?) constant to cover both cases (as they have the same text) and deprecate the other two? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes we can |
||
COM_FINDER_INDEX_PURGE_FAILED="Failed to delete selected items." | ||
COM_FINDER_INDEX_PURGE_SUCCESS="All items have been deleted." | ||
COM_FINDER_INDEX_SEARCH_DESC="Search in title, URL and last updated date." | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a personal opinion: I don't like this "loose" check here, but I'm aware that the
getPlugin
method sucks in general (not fault of this PR).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can agree with you,
but if my search results are not wrong
in core,
we already have more than 100 of this ...
out of scope of this pr