[5.1][com_finder] check if finder content plugin is enabled #42299

alikon · 2023-11-06T10:21:51Z

Pull Request for Issue #42296 .

Summary of Changes

correct the test if finder content plugin is enabled

Testing Instructions

Disable finder plugins, then start indexer

Actual result BEFORE applying this Pull Request

no message about disbled plugin

Expected result AFTER applying this Pull Request

message about disbled plugin

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

Fedik · 2023-11-06T17:25:39Z

I am sorry to say, but the fix is wrong.
Checking for plugins/content/finder is needed but you removing it here.

What probably needed to fix #42296 is to do an addittional check, whether at least one plugin is enabled in the finder group.

if (!PluginHelper::getPlugin('finder')) {
 $this->app->enqueueMessage('No Finder plugin found, please enable at least one', 'warning');
}

And this will be a new feature, not a bug fix.

alikon · 2023-11-06T18:29:56Z

no problem, you are right
...i've just forgot about the existence of plugin 'content/finder' too... 😨

I'll give it a closer look

administrator/language/en-GB/com_finder.ini

HLeithner · 2023-11-23T08:17:19Z

I don't think that this should go in 4.4 because it's not a bug.

alikon · 2023-11-23T09:40:27Z

switched to 5.1

fgsw · 2023-12-08T11:20:03Z

I have tested this item ✅ successfully on a455afe

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.}

alikon · 2024-01-14T10:28:32Z

should be aligned now

ufuk-avcu · 2024-02-24T10:05:54Z

I have tested this item ✅ successfully on 273a98d

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.}

nielsnuebel · 2024-02-24T10:21:03Z

I have tested this item ✅ successfully on 273a98d

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.}

richard67 · 2024-02-24T10:23:53Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.}

crimle · 2024-02-24T10:39:34Z

I have tested this item 🔴 unsuccessfully on 273a98d

Plugin Extension - Finder disabled
Components > Smart Search > Index > Button [Index]
There is no error message

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.}

richard67 · 2024-02-24T10:42:41Z

I have tested this item 🔴 unsuccessfully on 273a98dPlugin Extension - Finder disabled Components > Smart Search > Index > Button [Index] There is no error message

@crimle It needs to disable all plugins in the "Finder" group, i.e. all with names like "Finder - ...".

dorisdreher · 2024-02-24T10:50:58Z

I have tested this item 🔴 unsuccessfully on 273a98d

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.}

richard67 · 2024-02-24T10:53:32Z

I have tested this item 🔴 unsuccessfully on 273a98d

@dorisdreher Could you report back what has not worked? Maybe you've disabled the wrong plugins? Check also my previous comment.

crimle · 2024-02-24T11:06:23Z

I have tested this item 🔴 unsuccessfully on 273a98dPlugin Extension - Finder disabled Components > Smart Search > Index > Button [Index] There is no error message

@crimle It needs to disable all plugins in the "Finder" group, i.e. all with names like "Finder - ...".
There is one plugin only when searching for «finder»

dorisdreher · 2024-02-24T13:02:51Z

I have tested this item ✅ successfully on 273a98d

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.}

crimle · 2024-02-24T13:03:07Z

I have tested this item ✅ successfully on 273a98d

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.}

bembelimen · 2024-03-02T15:22:06Z

administrator/language/en-GB/com_finder.ini

@@ -148,6 +149,7 @@ COM_FINDER_INDEX_NO_DATA="No content has been indexed."
 COM_FINDER_INDEX_OPTIMISE_FINISHED="Optimisation finished."
 COM_FINDER_INDEX_PLUGIN_CONTENT_NOT_ENABLED="The Smart Search Content Plugin is disabled. Changes to content will not update the Smart Search index until the Plugin is enabled."
 COM_FINDER_INDEX_PLUGIN_CONTENT_NOT_ENABLED_LINK="The %s is disabled. Changes to content will not update the Smart Search index if you do not enable this plugin."
+COM_FINDER_INDEX_PLUGIN_FINDER_NOT_ENABLED_LINK="The %s are disabled. Changes to content will not update the Smart Search index if you do not enable these plugins."


Can't we make one (new?) constant to cover both cases (as they have the same text) and deprecate the other two?

yes we can
but out of scope of this pr

bembelimen · 2024-03-02T15:23:13Z

administrator/components/com_finder/src/View/Index/HtmlView.php

@@ -154,6 +163,11 @@ public function display($tpl = null)
            $this->finderPluginId = FinderHelper::getFinderPluginId();
        }

+        // Check that the finder plugins are enabled
+        if (!PluginHelper::getPlugin('finder')) {


Just a personal opinion: I don't like this "loose" check here, but I'm aware that the getPlugin method sucks in general (not fault of this PR).

i can agree with you,
but if my search results are not wrong
in core,
we already have more than 100 of this ...

out of scope of this pr

finder plugin enabled

e8247ed

joomla-cms-bot added the PR-4.4-dev label Nov 6, 2023

alikon mentioned this pull request Nov 6, 2023

com_finder, indexer. No visible message if finder plugins are disabled #42296

Open

alikon marked this pull request as draft November 6, 2023 18:30

alikon added 3 commits November 8, 2023 08:23

better check

ed380ef

link

4c7d253

lang

c693df9

joomla-cms-bot added the Language Change This is for Translators label Nov 11, 2023

alikon changed the base branch from 4.4-dev to 5.1-dev November 11, 2023 07:34

alikon changed the base branch from 5.1-dev to 4.4-dev November 11, 2023 07:35

alikon added 2 commits November 11, 2023 08:35

Merge branch '4.4-dev' into patch-18

833c976

cs

4334e34

alikon marked this pull request as ready for review November 11, 2023 12:45

Quy reviewed Nov 12, 2023

View reviewed changes

administrator/language/en-GB/com_finder.ini Show resolved Hide resolved

HLeithner added the Feature label Nov 23, 2023

Merge branch '4.4-dev' into patch-18

203ae4a

alikon changed the base branch from 4.4-dev to 5.0-dev November 23, 2023 09:30

alikon requested a review from laoneo as a code owner November 23, 2023 09:30

alikon changed the base branch from 5.0-dev to 5.1-dev November 23, 2023 09:31

switch to 5.1

dc42fd0

joomla-cms-bot added the PR-5.1-dev label Nov 23, 2023

switch to 5.1

06b9f88

alikon changed the title ~~[4][com_finder] check if finder content plugin is enabled~~ [5.1][com_finder] check if finder content plugin is enabled Nov 23, 2023

alikon removed the PR-4.4-dev label Nov 23, 2023

Merge branch '5.1-dev' into patch-18

a455afe

alikon marked this pull request as draft January 13, 2024 10:32

alikon added 5 commits January 14, 2024 08:37

Merge branch '5.1-dev' into patch-18

08fafcf

follow-joomla#42447

4fc5c08

follow-joomla#42447

623c759

follow-joomla#42447

9615e31

follow-joomla#42447

16735d4

alikon marked this pull request as ready for review January 14, 2024 10:27

Merge branch '5.1-dev' into patch-18

273a98d

Hackwar added the PBF Pizza, Bugs and Fun label Feb 20, 2024

richard67 removed the PBF Pizza, Bugs and Fun label Feb 24, 2024

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 24, 2024

richard67 added the PBF Pizza, Bugs and Fun label Feb 24, 2024

bembelimen reviewed Mar 2, 2024

View reviewed changes

alikon closed this Apr 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.1][com_finder] check if finder content plugin is enabled #42299

[5.1][com_finder] check if finder content plugin is enabled #42299

alikon commented Nov 6, 2023

Fedik commented Nov 6, 2023 •

edited

alikon commented Nov 6, 2023

HLeithner commented Nov 23, 2023

alikon commented Nov 23, 2023

fgsw commented Dec 8, 2023

alikon commented Jan 14, 2024

ufuk-avcu commented Feb 24, 2024

nielsnuebel commented Feb 24, 2024

richard67 commented Feb 24, 2024

crimle commented Feb 24, 2024

richard67 commented Feb 24, 2024

dorisdreher commented Feb 24, 2024

richard67 commented Feb 24, 2024

crimle commented Feb 24, 2024

dorisdreher commented Feb 24, 2024

crimle commented Feb 24, 2024

bembelimen Mar 2, 2024

alikon Mar 11, 2024

bembelimen Mar 2, 2024

alikon Mar 11, 2024

[5.1][com_finder] check if finder content plugin is enabled #42299

[5.1][com_finder] check if finder content plugin is enabled #42299

Conversation

alikon commented Nov 6, 2023

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Fedik commented Nov 6, 2023 • edited

alikon commented Nov 6, 2023

HLeithner commented Nov 23, 2023

alikon commented Nov 23, 2023

fgsw commented Dec 8, 2023

alikon commented Jan 14, 2024

ufuk-avcu commented Feb 24, 2024

nielsnuebel commented Feb 24, 2024

richard67 commented Feb 24, 2024

crimle commented Feb 24, 2024

richard67 commented Feb 24, 2024

dorisdreher commented Feb 24, 2024

richard67 commented Feb 24, 2024

crimle commented Feb 24, 2024

dorisdreher commented Feb 24, 2024

crimle commented Feb 24, 2024

bembelimen Mar 2, 2024

Choose a reason for hiding this comment

alikon Mar 11, 2024

Choose a reason for hiding this comment

bembelimen Mar 2, 2024

Choose a reason for hiding this comment

alikon Mar 11, 2024

Choose a reason for hiding this comment

Fedik commented Nov 6, 2023 •

edited