Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Improve com users list view #42457

Merged
merged 5 commits into from Dec 14, 2023
Merged

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Dec 3, 2023

Pull Request for Issue # .

Summary of Changes

See users overview in backend. There are Informations ( user is activated, usage of MFA) which look like buttons but are only static informations. Just tried to click one of them and was surprised.
This is misleading.

Testing Instructions

See users overview in backend before and after patch: Hover the different buttons and information.

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 336919d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42457.

@Quy
Copy link
Contributor

Quy commented Dec 4, 2023

Before PR:
42457-before

After PR, it shows as activated but this is not the case as seen in the Before PR screenshot.
42457-after

@chmst
Copy link
Contributor Author

chmst commented Dec 4, 2023

Thank you for testing. The oroginal condition seems not correct, but it works now for me.

grafik

@chmst chmst changed the title Improve com users list view [4.4] Improve com users list view Dec 4, 2023
@brianteeman
Copy link
Contributor

suprised that the activate button is only one way but that is not really in the scope of this PR


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42457.

1 similar comment
@brianteeman
Copy link
Contributor

suprised that the activate button is only one way but that is not really in the scope of this PR


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42457.

@brianteeman
Copy link
Contributor

suprised that the activate button is only one way but that is not really in the scope of this PR

tested ok - (cant post on issues.j.o)

@chmst
Copy link
Contributor Author

chmst commented Dec 4, 2023

suprised that the activate button is only one way but that is not really in the scope of this PR

I also was surprised. But it means that the user has verified his e-mail and this cannot be set back, isn't it?

@fgsw
Copy link

fgsw commented Dec 4, 2023

Successfull Test shown in patchtester, not shown on github.

@Quy
Copy link
Contributor

Quy commented Dec 5, 2023

I have tested this item ✅ successfully on dd24d98


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42457.

@fgsw
Copy link

fgsw commented Dec 6, 2023

I have tested this item ✅ successfully on dd24d98

Thanks @chmst


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42457.

@Quy
Copy link
Contributor

Quy commented Dec 6, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42457.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 6, 2023
@Quy
Copy link
Contributor

Quy commented Dec 6, 2023

@MacJoom MacJoom merged commit 8958389 into joomla:4.4-dev Dec 14, 2023
2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 14, 2023
@laoneo laoneo added this to the Joomla! 4.4.2 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants