Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Update phpseclib to 3.0.34 #42470

Merged
merged 2 commits into from Feb 19, 2024

Conversation

SniperSister
Copy link
Contributor

Summary of Changes

Update phpseclib to 3.0.34 to fix https://nvd.nist.gov/vuln/detail/CVE-2023-49316.

Testing Instructions

Code review.

@richard67
Copy link
Member

This will also fix issue #42142 . See also my PR #42190 for that issue, which I've just closed in favour of this one here.

@richard67
Copy link
Member

I have tested this item ✅ successfully on a518908

Tested by code review + verified that the URL is correct.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42470.

@rdeutz
Copy link
Contributor

rdeutz commented Dec 20, 2023

Shouldn't we have also an update for composer.json, we have still "phpseclib/bcmath_compat": "^2.0.1"

@SniperSister
Copy link
Contributor Author

How is bcmath related to the PR @rdeutz ?

@richard67
Copy link
Member

@SniperSister Meanwhile there is a new release 3.0.35 available. Changelog see https://github.com/phpseclib/phpseclib/releases/tag/3.0.35 . Would it make sense to update this PR to that release?

@SniperSister
Copy link
Contributor Author

@richard67 as we have updated to 3.0.34 in the 5.x branch I would suggest we do the same here.

@MacJoom MacJoom merged commit 9ea824a into joomla:4.4-dev Feb 19, 2024
3 checks passed
@MacJoom MacJoom added this to the Joomla 4.4.3 milestone Feb 19, 2024
@MacJoom
Copy link
Contributor

MacJoom commented Feb 19, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants