New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Replace hard coded img element by JLayout joomla.html.image and DRY #42508
[5.1] Replace hard coded img element by JLayout joomla.html.image and DRY #42508
Conversation
Co-authored-by: Quy <quy@nomonkeybiz.com>
I have tested this item ✅ successfully on a1ba0fa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42508. |
Am I being daft here but you could always create an override for the module output. But now if you want to create an override then it will impact not just the image layout in the module but everywhere that the image layout is being used. |
isn't that great? |
I have tested this item ✅ successfully on a1ba0fa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42508. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42508. |
I have tested this item ✅ successfully on 0b6155a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42508. |
Thanks |
Pull Request for no Issue
This PR replaces #40618
After solving the merge conflicts there are just too many changed files.
Summary of Changes
This PR will change the hard coded
<img src=""...
inside the default view of mod_banners by a call to JLayout joomla.html.image and keeps it DRY.Testing Instructions
Actual result BEFORE applying this Pull Request
You will see a banner image on the page.
Expected result AFTER applying this Pull Request
You will see a banner image on the page. The same as BEFORE. The HTML output is also the same as BEFORE.
The only difference is that it is rendered by JLayout which allows users to create an override.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed