Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Allow custom fields form be manipulates like category form #42510

Merged
merged 16 commits into from Mar 3, 2024

Conversation

bembelimen
Copy link
Contributor

@bembelimen bembelimen commented Dec 13, 2023

Summary of Changes

Allow a component to manipulate the custom field form like you can do with category view

Testing Instructions

  • Apply patch
  • Open a field form from com_content in the backend
  • Check that you get the form here and can manipulate it.

$form->getName() should give com_fields.field.com_content.article

$form->removeField('display', 'params'); removes the "Automatic Display" field

Actual result BEFORE applying this Pull Request

No way to manipulate the form via PHP directly

Expected result AFTER applying this Pull Request

You can manipulate the form

@brianteeman
Copy link
Contributor

would love to test this if you could provide some realistic test instructions

@bembelimen
Copy link
Contributor Author

would love to test this if you could provide some realistic test instructions

Done

@brianteeman
Copy link
Contributor

would love to test this if you could provide some realistic test instructions

Done

I will have to pass on testing this then

Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: Harald Leithner <leithner@itronic.at>
@laoneo laoneo added the b/c break This item changes the behavior in an incompatible why. HEADS UP label Mar 2, 2024
@bembelimen bembelimen removed the b/c break This item changes the behavior in an incompatible why. HEADS UP label Mar 2, 2024
@chmst
Copy link
Contributor

chmst commented Mar 2, 2024

I have tested this item ✅ successfully on 343863b

Tested following the instruction and was able to manipulate coustoms fields.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42510.

@HLeithner
Copy link
Member

HLeithner commented Mar 3, 2024

I have tested this item ✅ successfully on a86650f

Tested with com_contact, call works site didn't break


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42510.

@richard67
Copy link
Member

I've restored @chmst 's test result in the issue tracker since the commit which has invalidated the test counter was just a clean branch update.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42510.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 3, 2024
@LadySolveig LadySolveig merged commit c2530c4 into joomla:5.1-dev Mar 3, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 3, 2024
@LadySolveig
Copy link
Contributor

Thank you! And also for support and testing @chmst @HLeithner @richard67

@Quy Quy added this to the Joomla! 5.1.0 milestone Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants