[5.1] Allow custom fields form be manipulates like category form#42510
Merged
LadySolveig merged 16 commits intojoomla:5.1-devfrom Mar 3, 2024
Merged
[5.1] Allow custom fields form be manipulates like category form#42510LadySolveig merged 16 commits intojoomla:5.1-devfrom
LadySolveig merged 16 commits intojoomla:5.1-devfrom
Conversation
brianteeman
reviewed
Dec 13, 2023
Contributor
|
would love to test this if you could provide some realistic test instructions |
Co-authored-by: Brian Teeman <brian@teeman.net>
…-cms into 5.1/custom-fields-form
Contributor
Author
Done |
Contributor
I will have to pass on testing this then |
HLeithner
reviewed
Mar 2, 2024
Co-authored-by: Harald Leithner <leithner@itronic.at>
HLeithner
reviewed
Mar 2, 2024
Co-authored-by: Harald Leithner <leithner@itronic.at>
Contributor
|
I have tested this item ✅ successfully on 343863b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42510. |
Member
|
I have tested this item ✅ successfully on a86650f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42510. |
Member
|
I've restored @chmst 's test result in the issue tracker since the commit which has invalidated the test counter was just a clean branch update. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42510. |
Contributor
|
Thank you! And also for support and testing @chmst @HLeithner @richard67 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Allow a component to manipulate the custom field form like you can do with category view
Testing Instructions
$form->getName()should givecom_fields.field.com_content.article$form->removeField('display', 'params');removes the "Automatic Display" fieldActual result BEFORE applying this Pull Request
No way to manipulate the form via PHP directly
Expected result AFTER applying this Pull Request
You can manipulate the form