com_contact. Rm unused order_up, order_dn

[ReLater]

order_up and order_dn are not used in Joomla core. Garbage from Joomla 1.6 or so.

Summary of Changes

Removed lines from com_contact list view.

// Preprocess the list of items to find ordering divisions.
// @todo: Complete the ordering stuff with nested sets
foreach ($this->items as &$item) {
 $item->order_up = true;
 $item->order_dn = true;
}

Testing Instructions

• Check the Joomla core if you find somewhere a code place where properties order_up or order_dn are used. You won't find one.
• Check that com_contact list view in Joomla backend works like before when these lines are removed.
• @Kubik-Rubik confirmed in german Joomla forum that these lines are garbage from Joomla 1.6 or so.

Actual result BEFORE applying this Pull Request

• Unused garbage in file.

Expected result AFTER applying this Pull Request

• No functional changes. Garbage removed.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[Quy]

I have tested this item ✅ successfully on f1ac63e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42581.}

[ChristineWk]

I have tested this item ✅ successfully on f1ac63e

Joomla 5.1.0-alpha2

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42581.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42581.}

[richard67]

RTC as it has 2 successful tests ... but it needs to be clarified with maintainers or release managers if this should be rebased to 5.1-dev.

[bembelimen]

Yes, 5.1 please

[LadySolveig]

Thank you @ReLater and also for testing @ChristineWk and @Quy !