Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] CLI: Renaming and improving output of core:update:check #42594

Merged
merged 3 commits into from Jan 18, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jan 3, 2024

Summary of Changes

The commands for core updates are not consistent right now. This is a first attempt at getting a system into these commands and improving the output. This PR renames the core:check-updates command to core:update:check (and adds an alias to keep it backwards compatible) and extends the output to display the current Joomla version and the update channel we are currently on.

An additional command core:update:set-channel will allow to set the update channel in the future.

Testing Instructions

  1. call php cli/joomla.php
  2. call php cli/joomla.php core:update:check
  3. call php cli/joomla.php core:check-updates

Actual result BEFORE applying this Pull Request

to 1.: See the command listed as core:check-updates
to 2.: See the command fail
to 3.: See the title "Joomla updates" and the text "You already have the latest Joomla version..."

Expected result AFTER applying this Pull Request

to 1.: See the command listed as core:update:check and with an alias of core:check-updates
to 2.: See the command go through successfully with the title "Joomla Update Status" and the currently selected update channel and the current Joomla version in addition to the next available version.
to 3.: See the command to also work successfully, like in 2.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@dautrich
Copy link

dautrich commented Jan 9, 2024

I have tested this item ✅ successfully on fcc5429


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42594.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on fcc5429


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42594.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42594.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 15, 2024
@Razzo1987 Razzo1987 merged commit 3760098 into joomla:5.1-dev Jan 18, 2024
3 checks passed
@Razzo1987
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 18, 2024
@Razzo1987 Razzo1987 added this to the Joomla! 5.1.0 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants