Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Template Long Description #42651

Merged
merged 6 commits into from Feb 3, 2024
Merged

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue identified with #42649 .

Summary of Changes

Complete the code that truncates long descriptions.
As seen in
administrator/components/com_modules/tmpl/module/edit.php
administrator/components/com_plugins/tmpl/plugin/edit.php
administrator/components/com_scheduler/tmpl/task/edit.php
But only partially seen in
administrator/components/com_templates/tmpl/style/edit.php

each element that used "JGLOBAL_SHOW_FULL_DESCRIPTION", have a parent element with onclick attribute...

Testing Instructions

Update the descrption of the cassiopeia template in language\en-GB\tpl_cassiopeia.ini so that it is over 500 characters long.

Actual result BEFORE applying this Pull Request

The entire description is displayed

Expected result AFTER applying this Pull Request

The description is truncated and a new tab is present with the full description

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: <link

  • No documentation changes for manual.joomla.org needed

Comment

Alternatively the partial support for this truncation functionality can be removed from com_templates

@sinahaghparast
Copy link

@brianteeman I saw changed file, thanks...

now it is better to choose one code style in these four file...

onclick="document.getElementById('myTab').activateTab(document.getElementById('description'));"
or
onclick="document.querySelector('[aria-controls=description]').click();"

@brianteeman
Copy link
Contributor Author

Anyone can submit a pull request

@toivo
Copy link
Contributor

toivo commented Jan 16, 2024

I have tested this item ✅ successfully on 6501649

Tested successfully in Joomla 5.1.0-alpha3-dev of 15 January.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42651.

@richard67
Copy link
Member

I've restored the previous human test result in the issue tracker as the 2 commits after the test were only a code style change and a clean branch update.

@Quy
Copy link
Contributor

Quy commented Jan 22, 2024

I have tested this item ✅ successfully on 585dfd6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42651.

@Quy Quy removed the Feature label Jan 22, 2024
@Quy
Copy link
Contributor

Quy commented Jan 22, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42651.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 22, 2024
@Quy Quy added the Feature label Jan 22, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 2, 2024
@LadySolveig LadySolveig merged commit 5b315ea into joomla:5.1-dev Feb 3, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 3, 2024
@LadySolveig
Copy link
Contributor

Thank you @brianteeman and also vor testing @toivo and @Quy

@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the satnight branch February 3, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants