New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Template Long Description #42651
Conversation
@brianteeman I saw changed file, thanks...now it is better to choose one code style in these four file... onclick="document.getElementById('myTab').activateTab(document.getElementById('description'));" |
Anyone can submit a pull request |
I have tested this item ✅ successfully on 6501649 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42651. |
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
I've restored the previous human test result in the issue tracker as the 2 commits after the test were only a code style change and a clean branch update. |
I have tested this item ✅ successfully on 585dfd6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42651. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42651. |
Thank you @brianteeman and also vor testing @toivo and @Quy |
thanks |
Pull Request for Issue identified with #42649 .
Summary of Changes
Complete the code that truncates long descriptions.
As seen in
administrator/components/com_modules/tmpl/module/edit.php
administrator/components/com_plugins/tmpl/plugin/edit.php
administrator/components/com_scheduler/tmpl/task/edit.php
But only partially seen in
administrator/components/com_templates/tmpl/style/edit.php
each element that used "JGLOBAL_SHOW_FULL_DESCRIPTION", have a parent element with onclick attribute...
Testing Instructions
Update the descrption of the cassiopeia template in
language\en-GB\tpl_cassiopeia.ini
so that it is over 500 characters long.Actual result BEFORE applying this Pull Request
The entire description is displayed
Expected result AFTER applying this Pull Request
The description is truncated and a new tab is present with the full description
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: <link
No documentation changes for manual.joomla.org needed
Comment
Alternatively the partial support for this truncation functionality can be removed from com_templates