New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Add main region on error page #42719
Conversation
You should also add the |
@Razzo1987 Yes, Brian is right, it should also be added in the else branch like I wrote in my comment which you referred to:
Here in 5.1-dev the line numbers stilll fit to my comment. |
Correct, thanks! |
@Razzo1987 Now it needs to adapt the testing instructions so that both cases are checked, with and without any module on an error-403 or error-404 position. |
I have tested this item ✅ successfully on c6d4534 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42719. |
1 similar comment
I have tested this item ✅ successfully on c6d4534 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42719. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42719. |
Thank you @Razzo1987 and also for testing to @brianteeman and @viocassel |
Pull Request related to #42652 .
Read comment #42652 (comment)
Now whe are changing the semantic.
Summary of Changes
Add
<main>
onerror.php
template page.Also when there is a module in the
error-*
positionTesting Instructions
Case 1: Go on page error and see the source
Case 2: Add module to
error-403
orerror-404
position. Go on page error and see the sourceActual result BEFORE applying this Pull Request
Case 1 and Case 2: There is no
<main>
elementExpected result AFTER applying this Pull Request
Case 1: Now the error message is inside the
<main>
elementCase 2: Now the module is inside the
<main>
elementLink to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Thanks to @brianteeman and @richard67 for the brainstorming ;)