Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Switching Folder::files() to framework version #42761

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Feb 5, 2024

Summary of Changes

The CMS filesystem package has been deprecated for some time now and is supposed to be removed in 6.0. This PR removes some of the dependencies of the CMS on the Folder class and switches that dependency to the framework class. So far this only switches calls to Folder::files() to the framework package. Where additional methods are called from the package, I didn't change it.

Testing Instructions

Codereview.

#40131 is another PR related to this effort.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Fedik
Copy link
Member

Fedik commented Feb 25, 2024

I have tested this item ✅ successfully on b94e597


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42761.

@Hackwar Hackwar added the RTC This Pull Request is Ready To Commit label Feb 26, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 2, 2024
@bembelimen bembelimen self-assigned this Mar 2, 2024
@bembelimen bembelimen merged commit 9cab892 into joomla:5.1-dev Mar 2, 2024
2 of 3 checks passed
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen removed their assignment Mar 2, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 2, 2024
@Hackwar Hackwar deleted the 5.1-filesystem-folder-files branch March 4, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants