Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5][plugin] emailcloack Deprecated: mb_strpos() #42865

Merged
merged 5 commits into from Mar 27, 2024

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Feb 23, 2024

Pull Request for Issue #42846 .

Summary of Changes

don't cloack if null

Testing Instructions

see #42846

Actual result BEFORE applying this Pull Request

You'll get the error: Deprecated: mb_strpos()

Expected result AFTER applying this Pull Request

no more Deprecated

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon changed the title Deprecated: mb_strpos() [5][plugin] emailcloack Deprecated: mb_strpos() Feb 23, 2024
@alikon alikon added the PHP 8.x PHP 8.x deprecated issues label Feb 23, 2024
@alikon alikon marked this pull request as ready for review February 23, 2024 17:52
@RickR2H
Copy link
Member

RickR2H commented Feb 24, 2024

I have tested this item ✅ successfully on 6f2c9b9

Patch works!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42865.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 6f2c9b9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42865.

@joomla-cms-bot joomla-cms-bot removed PHP 8.x PHP 8.x deprecated issues PR-5.0-dev labels Feb 24, 2024
@alikon
Copy link
Contributor Author

alikon commented Feb 24, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42865.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 24, 2024
@richard67 richard67 added PHP 8.x PHP 8.x deprecated issues PR-5.0-dev labels Feb 24, 2024
@LadySolveig LadySolveig changed the base branch from 5.0-dev to 5.1-dev March 3, 2024 22:26
@bembelimen bembelimen merged commit 4ecd0b1 into joomla:5.1-dev Mar 27, 2024
1 check was pending
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 27, 2024
@alikon alikon deleted the patch-24 branch March 28, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants