Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] WebAssetManager: reset sorting state when new item enabled or disabled #42880

Merged
merged 2 commits into from Feb 26, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Feb 25, 2024

Summary of Changes

WebAsset ignoring newly added assets (without dependencies) after #42661
This PR is fixing it.

Testing Instructions

Apply patch, visit home page, and check for Schema.org markup in source code.

Actual result BEFORE applying this Pull Request

None (except BreadcrumbList)

Expected result AFTER applying this Pull Request

It is there

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@crommie
Copy link

crommie commented Feb 26, 2024

Without patch: only breadcrumb stuff
With patch: all schema.org

(Debug switched off)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42880.

@crommie
Copy link

crommie commented Feb 26, 2024

I have tested this item ✅ successfully on 3f09ba1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42880.

1 similar comment
@Hackwar
Copy link
Member

Hackwar commented Feb 26, 2024

I have tested this item ✅ successfully on 3f09ba1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42880.

@Hackwar Hackwar added the RTC This Pull Request is Ready To Commit label Feb 26, 2024
@richard67 richard67 removed RTC This Pull Request is Ready To Commit Release Blocker bug PR-5.1-dev labels Feb 26, 2024
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42880.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 26, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 26, 2024
@LadySolveig LadySolveig merged commit f4876ca into joomla:5.1-dev Feb 26, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 26, 2024
@Fedik Fedik deleted the webasset-fix-cache branch February 26, 2024 10:33
@LadySolveig
Copy link
Contributor

Thank you @Fedik and and for the speedy testers @crommie @Hackwar ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants